Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343443

Summary:

org.eclipse.mylyn.versions-feature is missing dependendies in feature.xml

Product:

z_Archived

Reporter:

Severin Gehwolf <sgehwolf>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

0.7.1

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch.	none
committed patch	none
mylyn/context/zip	none
forward ported patch	none
mylyn/context/zip	none

Description Severin Gehwolf

2011-04-20 13:49:21 EDT

Feature org.eclipse.mylyn.versions is missing some dependencies without them it can't be built. I encountered this problem while working on RPMs for Fedora.

- org.eclipse.mylyn.commons.core
- org.eclipse.mylyn.team.ui (which in turn has org.eclipse.mylyn_veature as a dependency)

Comment 1 Severin Gehwolf

2011-04-20 13:51:22 EDT

Created attachment 193729 [details]
Proposed patch.

Explicitly list dependencies in feature.xml

Comment 2 Steffen Pingel

2011-04-20 14:32:04 EDT

Hmm, the Versions feature must not depend on org.eclipse.mylyn_feature or org.eclipse.mylyn.team.ui and there should also be no reverse dependency.

I am happy to add the requirement on org.eclipse.mylyn.commons.core but it that going to fix the build problem for you?

Comment 3 Severin Gehwolf

2011-04-20 14:55:24 EDT

There is a Require-Bundle:  org.eclipse.mylyn.team.ui in org.eclipse.mylyn.versions.ui (which org.eclipse.mylyn.versions feature builds) Thoughts?

Comment 4 Steffen Pingel

2011-04-20 15:03:37 EDT

Created attachment 193740 [details]
committed patch

Comment 5 Steffen Pingel

2011-04-20 15:04:57 EDT

That is indeed a mistake. I have removed the bogus dependency on org.eclipse.mylyn.team.ui and added the org.eclipse.mylyn.commons.core dependency for the feature.

Comment 6 Steffen Pingel

2011-04-20 15:04:59 EDT

Created attachment 193741 [details]
mylyn/context/zip

Comment 7 Steffen Pingel

2011-04-20 15:17:09 EDT

Created attachment 193743 [details]
forward ported patch

Comment 8 Steffen Pingel

2011-04-20 15:17:11 EDT

Created attachment 193744 [details]
mylyn/context/zip

Comment 9 Steffen Pingel

2011-04-20 15:18:15 EDT

I have committed the fix to the e_3_7_m_3_5_x branch and head. Severin, please let me know in case that does not resolve the problem you were experiencing.

Comment 10 Severin Gehwolf

2011-04-20 15:31:06 EDT

It builds fine now. Nice, less deps :)