Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343372

Summary:	[CompositeStructure Diagram] [Enhancements] CompositeStructure Diagram needs to be regenerated
Product:	[Modeling] Papyrus	Reporter:	Vincent Lorenzo <vincent.lorenzo>
Component:	Core	Assignee:	Yann Tanguy <yann.tanguy>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.8.0
Target Milestone:	0.8.0
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	343359
Bug Blocks:	343361

Description Vincent Lorenzo

2011-04-20 07:24:57 EDT

Cloned from: 343361: [AllDiagrams] [Enhancements]All diagrams need to be regenerated
https://bugs.eclipse.org/bugs/show_bug.cgi?id=343361

The enhancements provided by the bug 343092, bug 335987, bug 342954 need a regeneration of each diagram.
I have created 3 new gmfgen nodes which are described here : http://wiki.eclipse.org/Papyrus_Developer_Guide/Papyrus_diagram_generation#Papyrus_Extension_Root_Node_Description

for the bug 343092 : 
- all compartments with title should have the field "Needs Title" set to true
-> a new tool in oep.gmfgenextension allows to change this field on the selected compartment
- to hide the title, you should use the new gmfgen node: Compartment Title Visibility Preference

for the bug 335987
- all external nodes labels and link labels should be referenced by the new GMFGen Node Label Visibility Preferences. 
-> icons for role are located in oep.diagram.common/label_role
-> warning with the preferences pages :
for example : 
same pages for AssociationNode, AssociationLink and AssociationBranchLink
-> now we should have a page for AssociationLink and AssociationNode (change the field "DisplayName" in the gmfgen of the element
-> AssociationBranch and AssociationLink should have the same "Display Name", BUT AssociationBranch should be located before AssociationLink in the model

- the element which have labels should provides the EditPolicy ShowHideLabelEditPolicy
-> for links it is done in a super class
-> for node, you should provide it in the GMFGen (a tool is provided in oep.gmfgenextension)

for the bug 342925
- a new node Compartment Visibility Preference allows to define hidden compartments by default. Currently, I'm not sure it is be useful.

Best Regards, 
-- 
Vincent Lorenzo

Comment 1 Yann Tanguy

2011-04-20 10:55:47 EDT

Done.
In r4150 - re-generation of Composite Structure Diagram
In r4512 - re-format of Composite Structure Diagram + header update.

Comment 2 Vincent Lorenzo

2011-04-20 11:43:29 EDT

I reopen the bug because : 
	- the new node Label Visibility Preference is never used
	- the nodes which have External Node Label should provide the custom behavior ShowHideLabelEditPolicy

Comment 3 Yann Tanguy

2011-04-21 01:08:57 EDT

In r4517
- node label visibility added
- ShowHideLabelEditPolicy added where necessary
- 2 unused compartment removed (InterfaceCompartment & InterfaceCompartmentCN)
- compartment titles modified

Comment 4 Vincent Lorenzo

2013-03-13 10:01:34 EDT

I close this bug.