Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343334

Summary: org.eclipse.jst.enterprise_userdoc.feature has no license file (in maintenance)
Product: [WebTools] WTP EJB Tools Reporter: David Williams <david_williams>
Component: jst.ejbAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact: Kaloyan Raev <kaloyan>
Severity: normal    
Priority: P3 CC: katep
Version: unspecifiedFlags: david_williams: pmc_approved+
Target Milestone: 3.2   
Hardware: PC   
OS: Linux   
Whiteboard: PMC

Description David Williams CLA 2011-04-20 00:01:27 EDT
org.eclipse.jst.enterprise_userdoc.feature has no license file in the maintenance build. This is because it is (trying) to use the "new" add-license-during-build technique, but that technique is not enabled in that stream. 

For a while, this has been showing up as "has different license" during releng tests. I've been thinking this was simply the newest (2011) license (EUA) file, but in fact it should say "license is missing". It say "different" due to inadequacy of the releng test, which ends up seeing "%license" as the license text. From repo content.xml: 

      <licenses size='1'>
        <license uri='license.html' url='license.html'>
          %license
        </license>
      </licenses>
      <copyright>
        %copyright
      </copyright>
Comment 1 David Williams CLA 2011-04-20 00:09:32 EDT
While there might be a way to get the new technique to work, it'd involve a lot of changes to builder, and mix and match of pde builder, compiler, etc., which I'd prefer not to do 

I know the goal was to avoid having to "dual stream" this simple feature ... but, I recommend we do, as the easiest way to get its license back using old style.
Comment 2 David Williams CLA 2011-04-20 01:02:06 EDT
Apparently, this error in maintenance was a simple error, and we could almost simply revert to the version in R3_2_maintenance. In fact, that was the first step I did in fixing this. But, then there's the problem of how to increment fields ... it probably needed a service increase due to some change in a doc bundle, which would have made it 3.2.200, but ... we have been providing it in several maintenance builds as 3.3.10 ... so, I hate to go "down" in versioning, even from week to week (since, I know that it might cause problems for adopters who simply collect a pool of features/bundles, and then pull "highest version" to build against and package. 

So, even though the minor field should not normally increase in maintenance stream, I do not think would be an issue here, especially since doc feature ... and, seems best to "choose the lessor of two evils". So, I reverted the "technique" of getting the feature to R3_2_maintenance, but let the version stay at 3.3.10 as it is in Indigo release (and, as we've been delivering for several weeks). 

Please feel free to speck up if anyone has a different view. 


FYI, this component needs a 3.2.4 target, so set target to 3.2 for now.
Comment 3 David Williams CLA 2011-04-20 14:12:01 EDT
Just to document it, I somehow "stepped on" the HEAD version of the map file that references this feature. I will restore the HEAD version back to what it had before latest I-build ... and hope I updated/released maintenance map correctly?