| Summary: | [ui] Misleading JavaDoc in ProvisionUI class | ||
|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Eugene Ostroukhov <eostroukhov> |
| Component: | p2 | Assignee: | P2 Inbox <equinox.p2-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | pascal |
| Version: | 3.6.2 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | stalebug | ||
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
ProvisionUI::openInstallWizard JavaDoc states that initialSelections can be null. In my code I left it null by provided operation, e.g.: final InstallOperation operation = ui.getInstallOperation(ius, uris); ui.openInstallWizard(null, operation, null); and all I got was NPE: Caused by: java.lang.NullPointerException at org.eclipse.equinox.internal.p2.ui.dialogs.PreselectedIUInstallWizard.<init>(PreselectedIUInstallWizard.java:35) at org.eclipse.equinox.p2.ui.ProvisioningUI.openInstallWizard(ProvisioningUI.java:208) ... I believe the trick is that initialSelections should not be null when operation is not null. The code worked as expected when I used same list to both init the operation and pass as initialSelections I believe the fix should be one of: 1. Amend JavaDoc. 2. Fix the method to use ius from the operation to populate initialSelections