Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 343261

Summary: PlatformUITest.testWithoutDisplayAccess_sync() fails on Java 7
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Oleg Besedin <ob1.eclipse>
Status: RESOLVED FIXED QA Contact: Oleg Besedin <ob1.eclipse>
Severity: normal    
Priority: P3 CC: ob1.eclipse, pwebster, remy.suen
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: PC   
OS: Linux-GTK   
Whiteboard:
Bug Depends on:    
Bug Blocks: 342688    
Attachments:
Description Flags
Patch none

Description Dani Megert CLA 2011-04-19 09:10:49 EDT 
HEAD.

PlatformUITest.testWithoutDisplayAccess_sync() fails when run on a Java 7 JRE.

This test failed on two subsequent runs of the Eclipse SDK tests against an Oracle Java 7 JRE. Unfortunately I cannot reproduce it when running on my Windows or Linux box.

See also bug 331909.
Comment 1 Oleg Besedin CLA 2011-04-25 13:22:03 EDT 
Created attachment 194006 [details]
Patch

I can't reproduce that either. One possibility is that we don't re-sync values on several variables in the RCPTestWorkbenchAdvisor: the setters are done in "synchronized" blocks but getters access variables directly. 

Also the order of PlatformUITest still was incorrect: "testCreateAndRunWorkbenchWithExceptionOnStartup" should be done after testing all startup variables for the normal case. (The test variables are static.)

I'll also bunch together all asserts of startup variables; there is little reason to have them in separate tests.
Comment 2 Oleg Besedin CLA 2011-04-25 13:26:36 EDT 
Patch applied to CVS Head.
Comment 3 Dani Megert CLA 2011-04-26 05:26:45 EDT 
Thanks Oleg. We'll run the tests against Java 7 again once the remaining issues are fixed (see bug 342688).