Bug 343171

Comment 1 Stephan Eberle 2011-04-19 04:35:31 EDT

(In reply to comment #0)
Some minor change requests wrt  descriptions:

> The org.eclipse.sphinx.xtendxpand.ui plug-in should provide wizards & pages for
> model to model transformation.
> 
> This plug-in should include therefore:
> - extension group (org.eclipse.sphinx.xtendxpand.ui.groups.ExtensionGroup) that
> allow selecting the Xtend file & the extension to be used;

... & the function to be used.

> - org.eclipse.sphinx.xtendxpand.ui.wizards.pages.OutletsConfigurationPage for
> configuring the outlets to be used for Xpand.

No, this makes sense for M2T only but not for M2M. But we should provide a CheckConfigurationPage which provides a check groups enabling users to select Check files that should be applied before running the model transformation.

> org.eclipse.sphinx.xtendxpand.ui.jobs.ConvertToXtendXpandEnableAutosarProjectJob
> allowing converting a project toward an Autosar project with Xtend/Xpand
> nature...

Never say AUTOSAR in Sphinx. All AUTOSAR-specific stuff must exclusively remain in Artop.

ConvertToXtendXpandEnableAutosarProjectJob => ConvertToXtendXpandEnabledProjectJob
(attention includes Enable => Enabled!)

... allowing to convert a project toward Java+Plug-in project with Xtend/Xpand nature


> - Rename org.eclipse.sphinx.emf.mwe.resourcesIScopingResourceLoader to Rename
> org.eclipse.sphinx.emf.mwe.resourcesWorkspaceResourceLoader.

org.eclipse.sphinx.emf.mwe.resources.IWorkspaceResourceLoader

Ok for all other change proposals.

Comment 2 Idrissa Dieng 2011-04-19 05:00:09 EDT

(In reply to comment #1)
> (In reply to comment #0)
> Some minor change requests wrt  descriptions:
> 
> > The org.eclipse.sphinx.xtendxpand.ui plug-in should provide wizards & pages for
> > model to model transformation.
> > 
> > This plug-in should include therefore:
> > - extension group (org.eclipse.sphinx.xtendxpand.ui.groups.ExtensionGroup) that
> > allow selecting the Xtend file & the extension to be used;
> 
> ... & the function to be used.

OK 

> 
> > - org.eclipse.sphinx.xtendxpand.ui.wizards.pages.OutletsConfigurationPage for
> > configuring the outlets to be used for Xpand.
> 
> No, this makes sense for M2T only but not for M2M. But we should provide a
> CheckConfigurationPage which provides a check groups enabling users to select
> Check files that should be applied before running the model transformation.

YES. 
CheckConfigurationPage provides a check groups enabling users to select
 Check files that should be applied before running the model transformation (like for M2T).

OutletsConfigurationPage is annother page that make sense only for M2T and provides a wizard page that allow configuring outlets like in OutletsPreferencePage.

> 
> > org.eclipse.sphinx.xtendxpand.ui.jobs.ConvertToXtendXpandEnableAutosarProjectJob
> > allowing converting a project toward an Autosar project with Xtend/Xpand
> > nature...
> 
> Never say AUTOSAR in Sphinx. All AUTOSAR-specific stuff must exclusively remain
> in Artop.
> 
> ConvertToXtendXpandEnableAutosarProjectJob =>
> ConvertToXtendXpandEnabledProjectJob
> (attention includes Enable => Enabled!)
> 
> ... allowing to convert a project toward Java+Plug-in project with Xtend/Xpand
> nature

OK

> 
> 
> > - Rename org.eclipse.sphinx.emf.mwe.resourcesIScopingResourceLoader to Rename
> > org.eclipse.sphinx.emf.mwe.resourcesWorkspaceResourceLoader.
> 
> org.eclipse.sphinx.emf.mwe.resources.IWorkspaceResourceLoader

OK
> 
> Ok for all other change proposals.

See proposed patch.

Comment 3 Idrissa Dieng 2011-04-19 05:01:29 EDT

Created attachment 193557 [details]
The org.eclipse.sphinx.xtendxpand.ui plug-in should provide wizards & pages for model to model transformation.

Comment 4 Idrissa Dieng 2011-04-19 05:03:55 EDT

Created attachment 193558 [details]
The org.eclipse.sphinx.xtendxpand.ui plug-in should provide wizards & pages for model to model transformation.

Comment 5 Idrissa Dieng 2011-04-19 10:50:28 EDT

Created attachment 193587 [details]
The org.eclipse.sphinx.xtendxpand.ui plug-in should provide wizards & pages for model to model transformation.

Comment 6 Idrissa Dieng 2011-04-19 12:22:14 EDT

Created attachment 193598 [details]
provides M2M functionnalities

Comment 7 Idrissa Dieng 2011-04-20 04:33:12 EDT

Created attachment 193667 [details]
provides M2M functionnalities

Comment 8 Idrissa Dieng 2011-04-20 05:56:40 EDT

Created attachment 193675 [details]
provides M2M functionnalities

Comment 9 Stephan Eberle 2011-04-20 06:32:19 EDT

Fixed by applying proposed patch with some minor improvements.

Comment 10 Balazs Grill 2021-07-14 02:17:22 EDT

Mass-closing Resolved tickets