Bugzilla – Full Text Bug Listing
| Summary: | Add region bundle tests to the build | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Watson <tjwatson> | ||||||||
| Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | david_williams, glyn.normington, kim.moir | ||||||||
| Version: | 3.7 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||
| Whiteboard: | stalebug | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Thomas Watson
Created attachment 193523 [details]
patch
Tom, the region bundle is added for the N20110419-2000 build. How do you want the tests to run if they aren't part of the SDK? What do they need to run? (In reply to comment #2) > Tom, the region bundle is added for the N20110419-2000 build. How do you want > the tests to run if they aren't part of the SDK? What do they need to run? The tests require the following to be installed org.eclipse.equinox.region (the implementation to test) org.eclipse.equinox.region.tests (the tests themselves) And the following two bundles from the orbit.map plugin@org.aspectj.runtime,1.6.7=p2IU,id=org.aspectj.runtime,version=1.6.7.20091231194938,repository=http://download.eclipse.org/tools/ajdt/aspectj/update plugin@org.easymock,2.4.0=p2IU,id=org.easymock,version=2.4.0.v20090202-0900,repository=http://download.eclipse.org/tools/orbit/downloads/drops/S20110304120314/repository Would that be difficult to setup for testing? There are two approaches to this 1) Change the existing build to run tests for a single bundle. Right now, our tests run by installing the test bundles into the SDK. 2)Create a new Hudson build that just builds Equinox incubator bundles and runs their tests. Advantage: faster build, faster test results. Thoughts? (Also, I couldn't get the php working on the test server for your test Equinox build Tom, I check it tonight on the real server. The php libaries seem to be different on the two machines and I'm not sure what is happening) (In reply to comment #4) > There are two approaches to this > 1) Change the existing build to run tests for a single bundle. Right now, our > tests run by installing the test bundles into the SDK. I don't mind this approach because we have other bundles in the Equinox SDK (not in the Eclipse SDK) with tests that we would like to run. Perhaps we could install the equinox test bundles and set of equinox bundles (region, coordinator, metatype etc) to test in one pass? > 2)Create a new Hudson build that just builds Equinox incubator bundles and runs > their tests. Advantage: faster build, faster test results. > Not sure I like this because I am not only talking about testing incubator bundles. > Thoughts? > > (Also, I couldn't get the php working on the test server for your test Equinox > build Tom, I check it tonight on the real server. The php libaries seem to be > different on the two machines and I'm not sure what is happening) The N-Build seems to be generated correctly for the region bundle. Okay, thanks for the clarification Tom, I'm writing a patch so the Equinox incubator tests can be invoked separately. Moving to RC1 for the so I can complete the portion of the bug where the tests are run for the incubator bundle. Created attachment 194535 [details]
preliminary patch to run tests for incubator bundles
Kim, I am working on some performance tests for regions that would require org.eclipse.core.tests.harness and org.eclipse.test.performance to be installed. Do you know if these two bundles will be installed as part of the test run? Tom, they are available in the repo, I'll modify the patch to include them in director call that installs the required bundles. I didn't realize there would be performance tests. The performance tests are called separately from the JUnit tests. Created attachment 194862 [details]
updated patch
Kim, is there anywhere we keep the source bundles for the inclubator bundles? No, not right now. These bundles are just included in a build time feature, their source bundles aren't generated at the moment. (In reply to comment #13) > No, not right now. These bundles are just included in a build time feature, > their source bundles aren't generated at the moment. You probably can guess my next question is: Can we get the source bundles generated? Regarding comment #14, I opened bug 345187 for this request. To clarify, the region bundle is in 3.7, just running the region tests is missing in the build. This is no longer valid. The region bundle is now part of the the Equinox SDK build. So you don't care about having the tests running? (In reply to comment #18) > So you don't care about having the tests running? Actually I do care about that, sorry. I renamed the defect and reopened. I would like to see this happen in Kepler. Still want to add these to Kepler? :) I'm asking because as I looked into the fact that org.aspectj.runtime is not signed, one thing I did was unzip our actual tests to look for it (see what version we were including, etc.) and was surprised I didn't see it. I think to run these tests, we've have to "include" org.aspectj.runtime in one of the test features ... right? So it gets packaged up? Not important for Kepler at this late stage. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |