Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342978

Summary: Refactor Tree widget to make it really virtual
Product: [RT] RAP Reporter: Ivan Furnadjiev <ivan>
Component: RWTAssignee: Project Inbox <rap-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: tbuschto
Version: 1.4   
Target Milestone: 1.5 M1   
Hardware: All   
OS: All   
Whiteboard: plan-version=1.5 plan-theme=widgets plan-status=committed
Bug Depends on:    
Bug Blocks: 332524, 336169    
Attachments:
Description Flags
Server-side refactoring none

Description Ivan Furnadjiev CLA 2011-04-15 10:09:53 EDT
Currently the virtual Tree widget is not really virtual. When the Tree#setItemCounts is called the TreeItem objects are created regardless the Tree is VIRTUAL or not.
Comment 1 Tim Buschtoens CLA 2011-05-06 14:16:02 EDT
Added implementation for setItemCount to TreeItem.js and Tree.js in CVS HEAD.
Comment 2 Ivan Furnadjiev CLA 2011-05-13 10:57:22 EDT
We did some refactoring on the server-side Tree as well. There are still some room for improvements like:
* Tree#setItemCount should not create items if tree is virtual.
* not use public methods like getItem( int ), getItems(), getItemCount() internally to avoid items creation
* rework getTopItem(), should not call collectVisibleItems (Performance)
* clean up collectVisibleItems
* improve flatIndices updating
Changes are in CVS HEAD.
Comment 3 Ivan Furnadjiev CLA 2011-05-13 10:59:50 EDT
Created attachment 195597 [details]
Server-side refactoring
Comment 4 Ivan Furnadjiev CLA 2011-08-08 05:19:45 EDT
All needed refactorings related to virtual behavior of the Tree are in CVS HEAD.