Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342942

Summary: Bug in PlainDriverDataSource isWrapperFor
Product: [RT] Gemini.JPA Reporter: Gunnar Wagenknecht <gunnar>
Component: CoreAssignee: Michael Keith <michael.keith>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: michael.keith: iplog+
Version: 1.0.0   
Target Milestone: 1.0.0 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch none

Description Gunnar Wagenknecht CLA 2011-04-15 06:14:34 EDT
Created attachment 193345 [details]
patch

acording to the usage in unwrap isWrapperFor should return true when the class matches, otherwise unwrap would throw a ClassCastException
Comment 1 Gunnar Wagenknecht CLA 2011-04-15 06:15:46 EDT
Comment on attachment 193345 [details]
patch

The patch also contains a project settings which prevents formatting of the code on save. This file can be skipped, though.
Comment 2 Michael Keith CLA 2011-06-02 16:48:11 EDT
Thanks for entering. 

Fixed both isWrapperFor() and unwrap() methods to comply with Wrapper interface including correct semantics of the method and throwing SQLException when appropriate.

Released into RC2.