Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342912

Summary: better "ignore mojo" quick-fix message
Product: z_Archived Reporter: Igor Fedorenko <igor>
Component: m2eAssignee: Milos Kleint <mkleint>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mkleint
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Igor Fedorenko CLA 2011-04-14 22:53:24 EDT 
User comment from #m2eclipse irc

<quote>
[20:31] <karlmd> igorf_: Ahh, I see that "ignore" actually adds something to the POM. I'd figured it was just a temporary fix. Apologies. You might want to change the Quick Fix to mention it's permanent.
</quote>

Sounds reasonable. We need to add "... permanently in pom.xml" somewhere in quick-fix description.
Comment 1 Milos Kleint CLA 2011-04-26 04:44:29 EDT 
the current wording of the quickfix is 
"Ignore goal XXX in Eclipse build"

it's used in problems view, xml editor quickfix action, editor hover (both form and xml)

Only the quickfix action has an additional popup area where more detailed information can be added. That leaves us with changing the  wording of the quickfix name alone.

possible rephrasing includes

1."Permanently mark goal XXX as ignored in Eclipse build"
2."Ignore goal XXX in Eclipse build (writes to pom.xml)"
3."Ignore goal XXX in Eclipse build - writes to pom.xml"
4. "Mark goal XXX in pom.xml as ignored in Eclipse build"
5. "Permanently mark goal XXX in pom.xml as ignored for Eclipse build"

my personal preference goes to 5, then 2. Not sure if "ignored for" is proper english though. 2. has the additional advantage of being more generic and could be used in future for all similar cases.


Can't resist to note however that for most users the permanency of the step will be obvious fairly fast. On the next review of the commit to scm (which everyone shall do all the time IMHO). And it's fairly easy to undo the change.
Comment 3 Denis Roy CLA 2021-04-19 13:25:03 EDT 
Moved to https://github.com/eclipse-m2e/m2e-core/issues/