Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342868

Summary: Context Help Editor Tree collapses on save
Product: [Eclipse Project] PDE Reporter: Miles Parker <milesparker>
Component: UIAssignee: Michael Rennie <Michael_Rennie>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public, Michael_Rennie
Version: 3.7   
Target Milestone: 3.8 M1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 353760    
Bug Blocks:    
Attachments:
Description Flags
fix for context help editor none

Description Miles Parker CLA 2011-04-14 12:57:41 EDT 
I get the following behavior pretty consistently, but not completely consistently:

1. Edit extension entries in PDE editor, for example object contributions in o.e.u.popupMenus.
2. Save the changes.
3. The editor tree collapses, and I need to navigate back to where I was before.

The reason that I thought this might be worth reporting now -- besides the minor annoyance factor -- is that it occurred to me that it might be related in some mysterious way to bug 331485.
Comment 1 Michael Rennie CLA 2011-06-07 13:15:11 EDT 
I also see this behavior using the context help editor (on Linux and Windows 7).

Steps:

1. add a new help context in the editor
2. add a new topic to the new context created in 1)
3. select the sub-topic
4. save

Expected:
nothing changes and the file is saved

Happens:
the selection is moved from the new sub-topic to the root of the tree and the tree flashes a few times.
Comment 2 Michael Rennie CLA 2011-06-07 13:17:45 EDT 
Created attachment 197523 [details]
fix for context help editor

Dug around in the code a bit and found there was a refresh method that was resetting the input to the tree and resetting the selection / expand level as well as firing a selection changed event for the root of the tree. 

The patch removes the overridden method and the editor works as expected.

I'll have a look and see if the extension editor is doing something similar.
Comment 3 Curtis Windatt CLA 2011-07-14 12:38:02 EDT 
I can easily reproduce in the context help editor and Mike's patch fixes it.  I have applied it to HEAD.

I haven't seen this behaviour in the extension editor.  Is it happening all the time for you?  Are you working with an existing plugin.xml with a lot of content or can you reproduce with a very small test case?
Comment 4 Curtis Windatt CLA 2011-07-28 15:31:33 EDT 
We haven't seen this problem in the plug-in editor since we fixed the corruption problem.  I'm renaming this bug and marking it as fixed.  If the original issue is still a problem in 3.7, please open a new bug.  Reproducing the issue in a clean workspace would be very beneficial.
Comment 5 Miles Parker CLA 2011-07-28 15:56:03 EDT 
Hi guys,

I've just been waiting to see if I see it happening anywhere in 3.7 and it doesn't appear to be. Good deal.

cheers,

Miles
Comment 6 Ankur Sharma CLA 2011-08-03 09:16:19 EDT 
Verified in I20110802-2000

However, Bug 353760 looks a regression to me.
Comment 7 Curtis Windatt CLA 2011-08-03 17:29:22 EDT 
I also verified that the patch fixes the collapse problem.  We will look at bug 353760 separately.