Bug 342854

Comment 1 Austin Riddle 2011-04-14 11:49:52 EDT

Also the semantic ordering of the sections is a little awkward.  I think that the browser section should be last with the preview url included from bug 342083.

Comment 2 Beyhan Veliev 2011-04-15 09:28:31 EDT

Created attachment 193367 [details]
Example for a new layout

This is just an example how we can optimize the layout of the main tab. I'm open for other suggestions.

Comment 3 Beyhan Veliev 2011-04-15 09:31:34 EDT

Created attachment 193369 [details]
WireframeSketcher screen file

I used the WireframeSketcher to create the example layout. Here is the WireframeSketcher file if you want to edit or change the example layout.

Comment 4 Rüdiger Herrmann 2011-04-15 09:39:03 EDT

I like the proposal!

Comment 5 Beyhan Veliev 2011-04-15 09:53:30 EDT

(In reply to comment #1)
>I think that the browser section should be last with the preview url included from bug 342083
I agree with you. But now we have an additional section "Instance area" which is a more advanced setting and not so important for RAP application developer. We want it to be the last section.
With this constrain the ordering "Servlet/Application -> Browser -> Runtime Settings -> Instance area" is in my IMO more reasonable then "Servlet/Application -> Runtime Settings -> Browser -> Instance area" because it is a top-down approach. 
May be Rüdiger and Ralf have other opinion about this?

Comment 6 Austin Riddle 2011-04-15 09:56:13 EDT

(In reply to comment #5)
> I agree with you. But now we have an additional section "Instance area" which
> is a more advanced setting and not so important for RAP application developer.
> We want it to be the last section.

Is there a reason why we need it to be on the main tab if it is not an important option?  Why not on the settings tab?

Comment 7 Rüdiger Herrmann 2011-04-15 09:59:31 EDT

(In reply to comment #5)
> [ ... ]
> With this constrain the ordering "Servlet/Application -> Browser -> Runtime
> Settings -> Instance area" is in my IMO more reasonable then
> "Servlet/Application -> Runtime Settings -> Browser -> Instance area" because it
> is a top-down approach.
> May be Rüdiger and Ralf have other opinion about this?
As long as the discussion is only about Browser -> Runtime Settings and vice versa, I am fine with both with a sligh preferrence towards Beyhans suggestion.

Comment 8 Rüdiger Herrmann 2011-04-15 10:06:42 EDT

(In reply to comment #6)
> 
> Is there a reason why we need it to be on the main tab if it is not an important
> option?  Why not on the settings tab?
Hm, you have a good point here :)
Only, the settings tab is provided by PDE and adding anything to it will most likely end in a hack.

Comment 9 Austin Riddle 2011-04-15 10:20:21 EDT

(In reply to comment #5)
> With this constrain the ordering "Servlet/Application -> Browser -> Runtime
> Settings -> Instance area" is in my IMO more reasonable then
> "Servlet/Application -> Runtime Settings -> Browser -> Instance area" because
> it is a top-down approach. 

Perhaps a better solution if you want to keep the ordering as Browser->Runtime
Settings is to move the URL preview to the end of the Runtime Settings section?
This makes more sense to me.  I think that the issue for me is not having the
preview URL before any settings that would change it.

Comment 10 Beyhan Veliev 2011-04-20 11:33:46 EDT

>Perhaps a better solution if you want to keep the ordering as Browser->Runtime
>Settings is to move the URL preview to the end of the Runtime Settings section?
I like the URL preview into the Browser Section because it belongs somehow to it. 
>I think that the issue for me is not having the preview URL before any settings that would change it.
I totally agree with you. 

After some discussions with Ralf we decided to implement the suggested layout (see RapLaunchNewLayout.png) for the current release of RAP. For the next release of RAP we will change the order of Browser Section and Runtime Section and also do other layout changes. I will provide a screen shot with our ideas soon. We don't want to do these layout changes now because we are quite close to our feature freeze deadline and there are other more important features waiting.

Comment 11 Beyhan Veliev 2011-04-20 11:36:28 EDT

Created attachment 193715 [details]
New Maint tab layout

Patch which implements the suggested Main tab layout.

Comment 12 Beyhan Veliev 2011-04-20 12:00:20 EDT

Created attachment 193717 [details]
Layout changes for RAP 1.5

This screen shot shows our ideas how to change the layout of the main tab for the next release. These ideas includes also the suggestions from bug 321719

Comment 13 Austin Riddle 2011-04-20 12:31:56 EDT

(In reply to comment #12)
> Created attachment 193717 [details]
> Layout changes for RAP 1.5
> 
> This screen shot shows our ideas how to change the layout of the main tab for
> the next release. These ideas includes also the suggestions from bug 321719

+1 I like it

Comment 14 Beyhan Veliev 2011-04-29 06:35:03 EDT

Created attachment 194346 [details]
Patch updated to CVS head

I updated the patch to the CVS head and did some refactoring.

Comment 15 Ralf Sternberg 2011-04-29 10:47:12 EDT

Applied patch to CVS HEAD with minor changes.