Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342769

Summary: [TMF] Refactoring of event cache with filter support and optimization of GUI refresh
Product: z_Archived Reporter: Patrick Tasse <patrick.tasse>
Component: LinuxToolsAssignee: Francois Chouinard <fchouinard>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed patch in org.eclipse.linuxtools.tmf.ui package fchouinard: iplog+

Description Patrick Tasse CLA 2011-04-13 17:11:47 EDT 
Build Identifier: 

Submitting a patch with the following improvements:

- The event cache is separated from the event table
- Filter support is added to the event cache
- The event table no longer stores a memory-unlimited list of filtered events
- The filter thread can store events in the event cache
- The search thread will first search in the event cache then in the trace
- The same search thread is used whether the table is filtered or not
- Searching backwards no longer reads only one event at a time for efficiency
- The selected event rank is now correctly updated after a search
- Synchronization is used to prevent queuing multiple GUI refreshes in the events table and time chart view
- The virtual table now correctly returns the selection index when the selection is outside of the visible range

Reproducible: Always
Comment 1 Patrick Tasse CLA 2011-04-13 17:13:06 EDT 
Created attachment 193199 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Patrick Tasse CLA 2011-04-13 17:20:09 EDT 
Also

- The filter thread request is now a TmfEventRequest instead of a TmfDataRequest, which prevented it from correctly being executed as a background request.
Comment 3 Francois Chouinard CLA 2011-04-14 10:17:56 EDT 
Comment on attachment 193199 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Thanks Patrick. Great job.
Comment 4 Francois Chouinard CLA 2011-04-14 10:18:31 EDT 
Patch committed.
Comment 5 Francois Chouinard CLA 2011-07-22 15:05:01 EDT 
Delivered with 0.8