Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342685

Summary: EditorWithStateTest and WorkingSetTest fail on Java 7
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Oleg Besedin <ob1.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ob1.eclipse, pwebster
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 342688    
Attachments:
Description Flags
UI test results
none
navigator test results
none
Patch none

Description Dani Megert CLA 2011-04-13 05:17:23 EDT
The EditorWithStateTest test fails on Java 7.

See attached test results.

The reason is that the test assumes to run in a certain order but that is not
guaranteed by JUnit.
Comment 1 Dani Megert CLA 2011-04-13 05:17:48 EDT
Created attachment 193137 [details]
UI test results
Comment 2 Dani Megert CLA 2011-04-13 05:21:05 EDT
Created attachment 193138 [details]
navigator test results
Comment 3 Dani Megert CLA 2011-04-13 05:22:09 EDT
>The EditorWithStateTest test fails on Java 7.
Same for WorkingSetTest.
Comment 4 Paul Webster CLA 2011-04-13 07:49:40 EDT
I think the solution is to add the tests in order to a suite for that class, instead of relying on reflection on EditorWithStateTest.class.

PW
Comment 5 Dani Megert CLA 2011-04-14 10:33:58 EDT
> Same for WorkingSetTest.

I've fixed that in HEAD (WorkingSetTest.java, rev. 1.11).
Comment 6 Oleg Besedin CLA 2011-04-14 15:07:20 EDT
Created attachment 193285 [details]
Patch
Comment 7 Oleg Besedin CLA 2011-04-14 15:07:57 EDT
Patch applied to CVS Head.
Comment 8 Dani Megert CLA 2011-04-15 03:27:11 EDT
Thanks for the fast fix Oleg!
Comment 9 Oleg Besedin CLA 2011-04-26 14:41:46 EDT
Verified that EditorWithStateTest and WorkingSetTest pass on I20110425-1800 using Java7.