Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342611

Summary:

Support GraphicsMixin for android browsers

Product:

[RT] RAP

Reporter:

Cole Markham <cole>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

tbuschto

Version:

1.4

Target Milestone:

---

Hardware:

Other

OS:

other

Whiteboard:

Attachments:

Description	Flags
Patch to add CSS3 Graphics Support	none

Description Cole Markham

2011-04-12 12:45:28 EDT

Since the Android browser supports neither VML nor SVG the app crashes with javascript errors in GraphicsUtil. The simple fix is to include null checks in GraphicsUtil, which keeps the app from crashing but isn't really usable. I also implemented the render class using CSS3 so that it works for webkit-based browsers like android. I added the check for Client.supportsCss3 after VML and SVG so it will only be used if the others are not available.

Also, Android 3.0 (Honeycomb) apparently now supports SVG so the check for supportsSvg which excludes all android browsers needs to be updated.

While implementing the renderer I noticed some odd behavior with background colors and images. For both SVG and VML, if you have border turned off then you can set both a background color and image. However when you turn on borders it disables the color and shows only the image. It doesn't matter the order the styles are applied. My implementation currently depends on the order the styles are set as to what gets displayed, but I would like to fix it once I know what the proper behavior should be.

Comment 1 Cole Markham

2011-04-12 13:55:32 EDT

Created attachment 193080 [details]
Patch to add CSS3 Graphics Support

The attached patch is against CVS HEAD although I am having trouble testing due to CVS issues. I tested against a slightly older version and it works great. I updated with the few new methods and I think they will work. Once I figure out how to get the tests to run and I get CVS head working, I will try to add test cases.

Comment 2 Tim Buschtoens

2012-02-01 05:01:19 EST

Can this bug be closed?
Fixing Bug 332509 should have solved thise issue, right?

Comment 3 Tim Buschtoens

2012-03-02 12:33:26 EST

Closing as WONTFIX, as the GraphicsMixin itself is and will not be supported on android. The client now uses CSS3 via the HTMLUtil.js instead, see Bug 332509.