Bugzilla – Full Text Bug Listing
|
Description
Krum Tsvetkov
See http://wiki.eclipse.org/UI_Graphics_:_Design_:_Style for some guidelines. The decorator is visible when the row is selected, which helps a little. The totals row sum sigma icon is also hard to read - just a faint red partial outline. These icons are provided by the org.eclipse.mat.api plugin via the org/eclipse/mat/snapshot/query/Icons.java class. This is meant to be independent of o.e.mat.ui or awt so it can run in batch mode, so we can't easily tell if we are in high contrast mode. Created attachment 224265 [details]
Example with blue arrow indicator
Here is an example screen shot showing the object icon with decorators in blue (40,98,150), the same colour as the array/class indicator. A darker blue would
be (0,64,128). The class and classloader decorators remain black as a comparison.
Does blue or black look best? If black looks best, is the difference small enough
that blue is acceptable given the improved visibility in high contrast mode?
This is also a problem with the new Eclipse dark themes. Updated the in/out icons, also the sum and @ address icon and superclass icon for better visibility in dark theme mode. Also updated the overview chart to have more readable text if the foreground colour is too close to background (as in dark theme mode the canvas is dark gray background, but black foreground). The HTML reports still have a white background in dark theme. New Gerrit change created: https://git.eclipse.org/r/128092 Gerrit change https://git.eclipse.org/r/128092 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=ff6fce8e2a7b7d61327fb1a9ea64fe542c4e0cf5 The icons have now been updated. The EcliPaint icon editor was very useful, though the icons are now about 600 bytes bigger. New Gerrit change created: https://git.eclipse.org/r/128137 Gerrit change https://git.eclipse.org/r/128137 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=4d961e435d28c71a3f84ee6d1492ca5035d83d4a New Gerrit change created: https://git.eclipse.org/r/128140 Gerrit change https://git.eclipse.org/r/128140 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=b80b22524fc253852e1d537c756fe7070c825974 New Gerrit change created: https://git.eclipse.org/r/128311 Gerrit change https://git.eclipse.org/r/128311 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=21fa8124c2b81302a3048ed7d6dd6159b8429c7f New Gerrit change created: https://git.eclipse.org/r/128317 Gerrit change https://git.eclipse.org/r/128317 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=e5247e955466ad618a129b6f7fb3c87006fe8960 New Gerrit change created: https://git.eclipse.org/r/128435 Gerrit change https://git.eclipse.org/r/128435 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=717ba4009a74e7a07f33896b21b60675777e5821 New Gerrit change created: https://git.eclipse.org/r/128460 Gerrit change https://git.eclipse.org/r/128460 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=979d6f4dba20ae2605acbeda3ee351651cde0b3c New Gerrit change created: https://git.eclipse.org/r/128480 Gerrit change https://git.eclipse.org/r/128480 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=89d37b74a65147b47e8f18a961c20769cdb9650c New Gerrit change created: https://git.eclipse.org/r/128489 Gerrit change https://git.eclipse.org/r/128489 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=0898f5b1db0bb3ac6f9e2a9486f62fec65cc699c New Gerrit change created: https://git.eclipse.org/r/128509 Gerrit change https://git.eclipse.org/r/128509 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=d76d57661bd6bea19dceac2d31b23d0737c86c8b New Gerrit change created: https://git.eclipse.org/r/128511 Gerrit change https://git.eclipse.org/r/128511 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=5c8d286cab75087a235a0423101e52f7e8e83e20 New Gerrit change created: https://git.eclipse.org/r/128561 Gerrit change https://git.eclipse.org/r/128561 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=856d1d3a3598a9b800b80d74c6a71153b2d36e7b |