Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342533

Summary:

[Model Navigator] Usage of a private constructor in oep.navigator.CreateDiagramAction and CreateDiagramActionProvider

Product:

[Modeling] Papyrus

Reporter:

Arnaud Cuccuru <arnaud.cuccuru>

Component:

Core

Assignee:

Arnaud Cuccuru <arnaud.cuccuru>

Status:

CLOSED INVALID

QA Contact:

Severity:

normal

Priority:

CC:

arnaud.cuccuru, rschnekenburger, sebastien.gerard

Version:

0.7.1

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch for oep.navigator	none

Description Arnaud Cuccuru

2011-04-12 06:09:08 EDT

Methods CreateDiagramAction::getCreationCommandRegistry() and CreateDiagramActionProvider::getCreationCommandRegistry() from oep.navigator make use of a private constructor: 
this.creationCommandRegistry = new CreationCommandRegistry(org.eclipse.papyrus.core.Activator.PLUGIN_ID);

It should be replaced by:
this.creationCommandRegistry = CreationCommandRegistry.getInstance(org.eclipse.papyrus.core.Activator.PLUGIN_ID);

Comment 1 Arnaud Cuccuru

2011-04-12 06:12:16 EDT

Created attachment 193022 [details]
patch for oep.navigator

Comment 2 Sébastien Gérard

2011-04-28 03:42:26 EDT

Arnaud, now that you are committer ;-), can you apply the patch and close the bug item?
thanks.

Comment 3 Arnaud Cuccuru

2013-03-28 05:27:02 EDT

This bug refers to an old version of Papyrus (0.7.1).
In the current version (Kepler M6), the code has been significantly refactored. The bug does not make sense anymore.
Closing the bug.