Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342521

Summary:	Toggle refactoring: Move to CRefactoring2
Product:	[Tools] CDT	Reporter:	Emanuel Graf <emanuel>
Component:	cdt-refactoring	Assignee:	Sergey Prigogin <eclipse.sprigogin>
Status:	RESOLVED FIXED	QA Contact:	Sergey Prigogin <eclipse.sprigogin>
Severity:	normal
Priority:	P3	CC:	cdtdoug, eclipse.sprigogin, malaperle, yevshif
Version:	8.0
Target Milestone:	8.1.0
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	347599
Bug Blocks:

Description Emanuel Graf

2011-04-12 05:00:39 EDT

Building the selected file AST can be really slow. CRefactoring2 and
RefactoringASTCache were introduced to fix that. BUT there is still an
unresolved issue with shared AST concurrency, see bug 292851. Using
CRefactoring2 would improve performance a lot and help with the index locking
issue previously mentioned so I suggest that you keep an eye on the bug.

Comment 1 Marc-André Laperle

2011-04-12 12:11:00 EDT

Also it should be possible to use SourceHeaderPartnerFinder and IASTTranslationUnit.getOriginatingTranslationUnit() instead of using
ToggleNodeHelper.getSiblingFile

Comment 2 Sergey Prigogin

2011-04-12 21:15:52 EDT

(In reply to comment #0)
> Building the selected file AST can be really slow. CRefactoring2 and
> RefactoringASTCache were introduced to fix that. BUT there is still an
> unresolved issue with shared AST concurrency, see bug 292851. Using
> CRefactoring2 would improve performance a lot and help with the index locking
> issue previously mentioned so I suggest that you keep an eye on the bug.

The concurrency issue with accessing shared AST has been resolved.

Comment 3 Sergey Prigogin

2012-02-24 20:44:49 EST

Fixed in master.