Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342519

Summary:

Toggle refactoring: misleading error message

Product:

[Tools] CDT

Reporter:

Emanuel Graf <emanuel>

Component:

cdt-refactoring

Assignee:

Marc-André Laperle <malaperle>

Status:

RESOLVED FIXED

QA Contact:

Emanuel Graf <emanuel>

Severity:

normal

Priority:

CC:

cdtdoug, malaperle

Version:

8.0

Target Milestone:

8.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Toggle Function, mutliple declarators message patch	malaperle: iplog-

Description Emanuel Graf

2011-04-12 04:58:10 EDT

In DeclaratorFinder.extractDeclarator, it returns null if it's a
IASTSimpleDeclaration and it has multiple declarators but the message is
"cannot work without declarator". I think a different message like "cannot work
with multiple declarators" would be more accurate

Comment 1 Marc-André Laperle

2011-04-12 12:47:08 EDT

Created attachment 193073 [details]
Toggle Function, mutliple declarators message patch

Patch. Also added missing copyrights in messages.properties.

Comment 2 Marc-André Laperle

2011-04-12 12:50:03 EDT

Fixed in HEAD.

Comment 3 CDT Genie

2011-04-12 13:23:17 EDT

*** cdt cvs genie on behalf of mlaperle ***
Bug 342519 - Toggle refactoring: misleading error message

[*] DeclaratorFinder.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/togglefunction/DeclaratorFinder.java?root=Tools_Project&r1=1.1&r2=1.2
[*] messages.properties 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/togglefunction/messages.properties?root=Tools_Project&r1=1.1&r2=1.2
[*] Messages.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/togglefunction/Messages.java?root=Tools_Project&r1=1.1&r2=1.2