Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342517

Summary: ConversionManager convertObjectToBoolean should return immutable Boolean.TRUE or Boolean.FALSE appropriately
Product: z_Archived Reporter: Jan <jan.vissers>
Component: EclipselinkAssignee: Nobody - feel free to take it <nobody>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch fixing instances of Boolean.valueOf(true) / Boolean.valueOf(false) in core none

Description Jan CLA 2011-04-12 04:34:29 EDT 
Build Identifier: 2.0.1.v20100213-r6600

The conversion of "true", "false" results in the manager creating new Boolean instances each and every time. This is not optimal, but also error-prone when doing equality check.

Reproducible: Always
Comment 1 David Minsky CLA 2011-04-28 17:42:34 EDT 
Created attachment 194318 [details]
Patch fixing instances of Boolean.valueOf(true) / Boolean.valueOf(false) in core
Comment 2 David Minsky CLA 2011-04-28 17:43:59 EDT 
Proposing attached patch to correct Boolean.valueOf(true) / Boolean.valueOf(false) usage within EL core to Boolean.TRUE / Boolean.FALSE respectively.
Comment 3 David Minsky CLA 2011-04-29 17:27:50 EDT 
Fix checked into trunk (2.3) at r9284
Comment 4 Eclipse Webmaster CLA 2022-06-09 10:32:26 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink