Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342501

Summary:	[client] compare page from git log always thinks its dirty
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-04-11 19:45:18 EDT

- open git log UI
- click on the "compare" button in actions column of the git log page to look at the diffs between current and the commit
- press the back button

You'll be prompted about unsaved changes.

Comment 1 libing wang

2011-04-12 09:59:11 EDT

might be wrong usage of editor container .

Comment 2 libing wang

2011-04-12 12:34:33 EDT

The reason was that I was using editorContainer.getEditorWidget().setText() directly , which caused the dirty mark to true.
I am using editorContainer.onInputChange() now . It resolves the dirty mark issue but seems that this function is creating a new styler every time.The new styler is adding lineStyle listener to the editor so it is competing with the diff styler.
I have to work it around by removing the lineStyle listener before  I call editorContainer.onInputChange().
I will wait until the final solution of bug 341141.

Comment 3 libing wang

2011-04-12 14:06:07 EDT

fixed with c7f2525f52eff86358714d20a2815b282b36eb34.
I am only calling editorContainer.onInputChange() once now , so bug 341141 is no longer blocking me.