Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342500

Summary:

[client] Use the commit link to show commit details in Log UI

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Client

Assignee:

Szymon Brandys <Szymon.Brandys>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

malgorzata.tomczyk, Szymon.Brandys

Version:

0.2

Target Milestone:

0.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
screenshot	none

Description Susan McCourt

2011-04-11 19:40:16 EDT

In the git log UI, there is a list of the commits for my file.
The commit has a link and if I click on it, it takes me to the coding page on that commit.
There is also a flashlight icon in the actions column that appears to do the same thing.

- Unless I'm misunderstanding, the action icon is not needed.  The link is nicer because it lets me open on page or in new tab.
- If we need the action for some reason, the icon is confusing.

Comment 1 Susan McCourt

2011-04-11 19:40:53 EDT

Created attachment 192989 [details]
screenshot

Comment 2 Szymon Brandys

2011-04-12 05:01:16 EDT

You are right. When I have time to go back to this, I plan to leave the icon to open the content and use the link to show commit details on the left/right side in the details pane. So far I'm going to leave it as it is.

I'm changing the summary to better match the reality.

Comment 3 Susan McCourt

2011-04-12 11:43:09 EDT

ok.  I suggest you use the word "Open" rather than the flashlight icon, until we can decide on a better icon.  

We've talked in other pages about having "Open" and "Open with..."

Comment 4 Szymon Brandys

2011-05-18 11:13:59 EDT

Fixed. The details panel shows commit details and the list of diffs. You may open the compare editor to see changes in diffs too.