Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342499

Summary: Minor update to Hermes parser after migrating EL integration to use the lastest
Product: z_Archived Reporter: Pascal Filion <pascal.filion>
Component: EclipselinkAssignee: Nobody - feel free to take it <nobody>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.b.bracken
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Changes required for EL integration to work with the previous changes made to the Hermes parser
none
Patch for the unit-tests
none
Latest dev update
none
Latest unit-tests update none

Description Pascal Filion CLA 2011-04-11 19:09:04 EDT
Created attachment 192987 [details]
Changes required for EL integration to work with the previous changes made to the Hermes parser

Migrating the EL integration (bug 338248) to use the latest changes made to the Hermes parser (bug 341523) required making some additional changes. The patches attached to this bug includes those changes.

Note: EL integration is no longer using it's own way of parsing the declaration of a query but uses the new declaration code that was added to Hermes with bug 341523. Minor changes were made to the basic behavior in order for EL to properly extend it.
Comment 1 Pascal Filion CLA 2011-04-11 19:10:14 EDT
Created attachment 192988 [details]
Patch for the unit-tests
Comment 2 Pascal Filion CLA 2011-04-22 14:17:10 EDT
Created attachment 193937 [details]
Latest dev update

This patch contains the latest enhancement work. The validators (grammatical and semantic validators) and the content assist have been cleaned and optimized
Comment 3 Pascal Filion CLA 2011-04-22 14:17:44 EDT
Created attachment 193938 [details]
Latest unit-tests update
Comment 4 John Bracken CLA 2011-04-26 14:59:44 EDT
I applied the patch, reviewed the code and ran the tests.  All of the tests pass and everything looks good.  +1
Comment 5 Pascal Filion CLA 2011-04-26 18:02:04 EDT
The patch has been committed into SVN.
Comment 6 Eclipse Webmaster CLA 2022-06-09 10:29:06 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink