Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342491

Summary:

Virgo's Manifest header parser is too strict

Product:

[RT] Virgo

Reporter:

Borislav Kapukaranov <b.kapukaranov>

Component:

runtime

Assignee:

Borislav Kapukaranov <b.kapukaranov>

Status:

RESOLVED WONTFIX

QA Contact:

Severity:

trivial

Priority:

CC:

frieder.heugel, glyn.normington

Version:

3.0.0.M03

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Vaadin 6.5.4 manifest	none

Description Borislav Kapukaranov

2011-04-11 17:30:20 EDT

Virgo's manifest header parser does not correspond to the following text in the OSGi core specification:
<spec>
Whitespaces between terminals are ignored unless specifically noted. Any 
value that contains a space, a comma, semi-colon, colon, equal sign or any 
other character that is part of a terminal in the grammar must be quoted.
</spec>

It fails to parse when having whitespace after a comma with the following error:
"HP005W:[col 14]: Unexpected space found"

Comment 1 Glyn Normington

2011-04-12 02:27:31 EDT

It would be helpful to attach a manifest that demonstrates this behaviour.

Comment 2 Frieder Heugel

2011-04-12 02:57:32 EDT

(In reply to comment #1)
> It would be helpful to attach a manifest that demonstrates this behaviour.

First time I've seen this behaviour was with the vaadin plugin that can be found here: http://vaadin.com/downloading?package=release/6.5/6.5.4/vaadin-6.5.4.jar. This bundle gets installed with Equinox while Virgo complains about the spaces (and the digit 16). However I can't reproduce that behaviour with an own bundle and comma space separation.

Comment 3 Frieder Heugel

2011-04-12 02:59:19 EDT

Created attachment 193000 [details]
Vaadin 6.5.4 manifest

Comment 4 Borislav Kapukaranov

2011-05-07 01:44:11 EDT

Actually this is not a bug. 
Virgo produces these warnings "HP005W:[col 14]: Unexpected space found"  during parsing of MANIFEST headers that contain white spaces between terminals. 
But these warnings are only visible when there is actually an error in the currently parsed header data.
This is why Frieder and i wasn't able to reproduce with own test bundle.

Virgo fails to deploy only when there are number-starting packages.
The result of installation of such MANIFESTs is not defined by the specification that is why Equinox isn't performing any checks.
Maybe it is better to align with them on this one and still allow the install but produce a visible warning that the installed bundle contains a manifest not compliant with the OSGi spec.

I'm changing the Name of the bug to cover the new direction it has taken.