Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342489

Summary:	[publisher] Errors in p2 tests printed to console while branding
Product:	[Eclipse Project] Equinox	Reporter:	DJ Houghton <dj.houghton>
Component:	p2	Assignee:	P2 Inbox <equinox.p2-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	trivial
Priority:	P3	CC:	pascal, t-oberlies
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:	stalebug

Description DJ Houghton

2011-04-11 16:23:53 EDT

During the investigation of bug 341781 it was noticed that we are seeing the following error message printed to the console when we run the p2 tests. 

Is it related to the recent integration of the publisher changes or did it exist before? 
Is this a problem? 

[java] Error - 6 icon(s) not replaced in
/tmp/p2.brandingIron3084785278937756120/eclipse.exe using
/tmp/LauncherName8776581383509947268.ico

Comment 1 Tobias Oberlies

2011-04-12 03:30:18 EDT

The root cause of the message is that the .ico file used for EquinoxExecutableActionTest.testWin() does not contain the icon in all required resolutions (see org.eclipse.pde.internal.swt.tools.IconExe.main(String[])). The icon file is taken from /org.eclipse.equinox.p2.tests/testData/EquinoxExecutableActionTest/win/eclipse.ico. Replacing this file by a "correct" icon would resolve the issue. (Does anyone have the right tools to create multi-resolution icons?)

Again, we should re-investigate the error handling after the Indigo release (see bug 342198).

Comment 2 Tobias Oberlies

2011-06-11 08:27:12 EDT

Independent of what we do for bug 342198, the message indicates that there is a problem in the test data: The icon used only contains one resolution - while the branding iron expects seven (see [1]). This should be easy to fix for someone who has an editor for ico files...

[1] /org.eclipse.equinox.p2.publisher.eclipse/src/org/eclipse/pde/internal/swt/tools/IconExe.java

Comment 3 John Arthorne

2012-04-18 14:17:44 EDT

FWIW I tried the test with the newest eclipse.ico for Juno from bug 341645 and got the same failure.

Comment 4 Eclipse Genie

2019-09-10 18:46:14 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.