Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342460

Summary: Run SDK tests against Oracle Java 7 JRE
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: RelengAssignee: Kim Moir <kim.moir>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P4 CC: john.arthorne, Olivier_Thomann, remy.suen
Version: 3.7   
Target Milestone: 3.8 M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
buildAll.xml
none
patch none

Description Dani Megert CLA 2011-04-11 11:58:50 EDT
We need to get a picture on how we're doing regarding Java 7 JREs. I'd like to run our SDK tests against the latest candidate.
Comment 1 Kim Moir CLA 2011-04-12 10:27:35 EDT
Running N20110411-2000 tests with with Java 7 right now.
Comment 2 Kim Moir CLA 2011-04-12 21:41:35 EDT
Dani, I'll email you the zip of the results. It's too big to attach to bugzilla.
Comment 3 Kim Moir CLA 2011-04-12 21:43:30 EDT
Also, as an aside, I think the reason that jdt.apt tests didn't run is that they require J2SE-6.0 to be defined in the scripts to run. I can change this to require J2SE-7.0.  I just ran all the tests with Java 7 only, not in addition to Java 6.
Comment 4 Dani Megert CLA 2011-04-13 03:57:09 EDT
(In reply to comment #3)
> Also, as an aside, I think the reason that jdt.apt tests didn't run is that
> they require J2SE-6.0 to be defined in the scripts to run. I can change this 
> to require J2SE-7.0.  I just ran all the tests with Java 7 only, not in 
> addition to Java 6.

Olivier, I assume they should also run against Java 7.0, right? Did you run them against Java 7 and they all passed? If so, we can wait to touch the build scripts for now.
Comment 5 Dani Megert CLA 2011-04-13 03:57:19 EDT
Kim, would it be possible to make the results available like normal build test results and keep them for a while so that teams have enough time to go through them?
Comment 6 Dani Megert CLA 2011-04-13 04:09:25 EDT
I suspect some of the failures are due to the PDE build error (bug 342622).
Comment 7 Dani Megert CLA 2011-04-13 04:25:09 EDT
The known ordering issue seems to hit some test suites. Another pattern is that some test throw a VerifyError. This needs to be investigated.
Comment 8 Kim Moir CLA 2011-04-13 11:05:35 EDT
The results are available here

http://download.eclipse.org/eclipse/downloads/drops/N20110411-2000/testResults.php

under the RHEL 5, SUN 1.7.0 heading.
Comment 9 Kim Moir CLA 2011-04-13 12:41:53 EDT
Closing.
Comment 10 Kim Moir CLA 2011-04-13 12:48:56 EDT
Created attachment 193173 [details]
buildAll.xml

Olivier, it's called from line 463 of the attached file.
Comment 11 Dani Megert CLA 2011-04-14 01:25:14 EDT
Kim, I'd like to keep this open until we have good results. I'd like to see the most bugs (see bug 342688) fixed and then run another test build again that has code coverage disabled. I'll ping here when it's time.
Comment 12 Kim Moir CLA 2011-04-19 11:40:01 EDT
There are new results here for Java 7 on Linux

http://download.eclipse.org/eclipse/downloads/drops/N20110417-2000/testResults.php

The jdt.ui.refactoring test results are still missing. That test suite seems to be stalling.
Comment 13 Dani Megert CLA 2011-04-19 11:45:17 EDT
I'm happy with the current state regarding the Oracle JRE. We have two remaining issues one of which is a known one in a JDT JUnit test.

Kim, if time's more quiet I'd also like to see how the IBM JRE does, but there's no hurry.
Comment 14 Dani Megert CLA 2011-04-28 04:55:51 EDT
All problems are supposed to be fixed by now. I'd like to rerun the tests during RC1 (low-prio).
Comment 15 Kim Moir CLA 2011-05-12 07:19:16 EDT
I'll rerun them this Friday.
Comment 16 Dani Megert CLA 2011-05-31 11:50:03 EDT
(In reply to comment #15)
> I'll rerun them this Friday.

I guess this didn't happen. Again, low prio.
Comment 17 Dani Megert CLA 2012-01-12 05:27:58 EST
Kim, we switch at least one machine to Oracle Java 7u2. I suggest to do this for Windows, but Linux also works for me.
Comment 18 Dani Megert CLA 2012-01-18 11:01:43 EST
(In reply to comment #17)
> Kim, we switch at least one machine to Oracle Java 7u2. I suggest to do this
> for Windows, but Linux also works for me.

Kim, we just discussed this in the PMC call and decided to go with Linux. The Juno plan will also list JRE 7 as one of the reference platforms.
Comment 19 Dani Megert CLA 2012-01-18 11:45:32 EST
(In reply to comment #18)
> (In reply to comment #17)
> > Kim, we switch at least one machine to Oracle Java 7u2. I suggest to do this
> > for Windows, but Linux also works for me.
> 
> Kim, we just discussed this in the PMC call and decided to go with Linux. The
> Juno plan will also list JRE 7 as one of the reference platforms.

Kim, if you already started to make them run under Windows, then that's also OK.
Comment 20 Kim Moir CLA 2012-01-18 16:27:27 EST
Created attachment 209706 [details]
patch

Released for N20120118-2000
Comment 21 Dani Megert CLA 2012-01-19 03:03:30 EST
(In reply to comment #20)
> Created attachment 209706 [details]
> patch
> 
> Released for N20120118-2000

http://download.eclipse.org/eclipse/downloads/drops/N20120118-2000/testResults.php

==> At least the column label is not reflecting this.
Comment 22 Kim Moir CLA 2012-01-19 15:04:28 EST
This has been fixed for N20120119-2000. Also, the tests that the builder specified that must run on 1.6 will also run 1.7.
Comment 23 Dani Megert CLA 2012-01-20 05:03:08 EST
(In reply to comment #22)
> This has been fixed for N20120119-2000. Also, the tests that the builder
> specified that must run on 1.6 will also run 1.7.

Yep, verified in N20120119-2000.

Keeping this bug open until we have solved the VerifyError issue.
Comment 24 Olivier Thomann CLA 2012-01-20 08:47:20 EST
(In reply to comment #23)
> Keeping this bug open until we have solved the VerifyError issue.
What VerifyError issue ?
Comment 25 Dani Megert CLA 2012-01-20 08:50:18 EST
(In reply to comment #24)
> (In reply to comment #23)
> > Keeping this bug open until we have solved the VerifyError issue.
> What VerifyError issue ?

In the tests. Most likely caused by JaCoCo. See e.g.:
http://download.eclipse.org/eclipse/downloads/drops/N20120119-2000/testresults/html/org.eclipse.ant.tests.core_win32.win32.x86_7.0.html
Comment 26 Olivier Thomann CLA 2012-01-20 08:53:40 EST
Most likely indeed. Do we know what version of Jacoco is used ?
I'll send the stack trace to Marc for investigation.
Comment 27 Kim Moir CLA 2012-01-20 11:37:46 EST
The Jacoco is the same one from last year - 0.5.0. This comment has the CQs

https://bugs.eclipse.org/bugs/show_bug.cgi?id=241254#c16
Comment 28 Kim Moir CLA 2012-01-20 15:40:45 EST
I've disabled the jacoco libraries from being on the classpath when running the tests on Windows.
Comment 29 Dani Megert CLA 2012-01-23 11:03:50 EST
(In reply to comment #28)
> I've disabled the jacoco libraries from being on the classpath when running the
> tests on Windows.

This did the trick and it also got confirmed by the JaCoCo provider that this was a known issue. Upgrade is tracked via bug 369405.