| Summary: | AST swallows stars ('*') at end of {@code} and {@literal} Javadoc fragments | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Markus Keller <markus.kell.r> | ||||
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | amj87.iitr, frederic_fusier, stephan.herrmann | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I think inside "inlined" tags everything between the {} must be selected.
Frédéric, do you see anything wrong with this ?
(In reply to comment #1) > I think inside "inlined" tags everything between the {} must be selected. > Frédéric, do you see anything wrong with this ? No, you're obviously right. Created attachment 193188 [details]
Proposed fix + regression test
(In reply to comment #3) > Created attachment 193188 [details] > Proposed fix + regression test Apparently looks ok... However, I wonder if that could not introduce a change in the formatter behavior. I'm running formatter massive regression tests to double-check... I didn't observe any behavior change while running massive formatter tests, hence +1 for the patch Thanks Frédéric. Released for 3.7M7. Verified for 3.7M7 using build I20110421-1800. |
HEAD AST swallows '*' at end of {@code} and {@literal} Javadoc fragments: package p; /** * Hello {@code stars*}.<br> * Bye {@literal stars****}.<br> * No stars*? Need {@code space* }? */ class A { } In the last example, the * is preserved because there's another character after the * (can be any character, doesn't have to be a space).