Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342355

Summary: [Query2] UI dependency added to a "NON-UI" plugin
Product: [Modeling] EMF Reporter: jgielstra Mising name <jgielstra>
Component: Query2Assignee: Project Inbox <emf.query2-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: manasa.priya.c, saurav.sarkar1
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
IndexPluginPatch
wayne.beaton: iplog+
IndexUIPluginPatch wayne.beaton: iplog+

Description jgielstra Mising name CLA 2011-04-09 10:51:38 EDT 
Build Identifier: M20110210-1200

org.eclipse.emf.query2.index had been modified adding 
org.eclipse.ui.views;bundle-version="3.4.0"  as dependency this UI dependent code should exist in the UI plugin (org.eclipse.emf.query2.index.ui) and not the base index one...  This adds extra deps when the plugin is being used headlessly ...



Reproducible: Always
Comment 1 saurav sarkar CLA 2011-04-11 09:11:02 EDT 
Hi,

Makes sense.We will work on this as soon as possible.

Also could you please let us know about your usage of Query2 ?
such that we keep you updated on changes and updates of Query2.

cheers,
Saurav
Comment 2 jgielstra Mising name CLA 2011-04-11 16:13:59 EDT 
(In reply to comment #1)
> Hi,
> 
> Makes sense.We will work on this as soon as possible.
> 
> Also could you please let us know about your usage of Query2 ?
> such that we keep you updated on changes and updates of Query2.
> 
> cheers,
> Saurav

Sure I have a number of Models that I index and query behind a Query Servlet.  I am using Equinox runtime on tomcat via the Equinox Servlet Bridge they provide.  So I have NO ui plugins e.g. org.eclipse.ui and workbench plugins.

BTW I logged another defect hacking support for BigInteger and Date ...
https://bugs.eclipse.org/bugs/show_bug.cgi?id=338164
Comment 3 saurav sarkar CLA 2011-04-12 06:35:52 EDT 
(In reply to comment #2)
> (In reply to comment #1)
> > Hi,
> > 
> > Makes sense.We will work on this as soon as possible.
> > 
> > Also could you please let us know about your usage of Query2 ?
> > such that we keep you updated on changes and updates of Query2.
> > 
> > cheers,
> > Saurav
> Sure I have a number of Models that I index and query behind a Query Servlet. 
> I am using Equinox runtime on tomcat via the Equinox Servlet Bridge they
> provide.  So I have NO ui plugins e.g. org.eclipse.ui and workbench plugins.
> BTW I logged another defect hacking support for BigInteger and Date ...
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=338164

We are acting on this bug actively.I think BigInteger support will be also done quickly but i am not sure on the date support.Because for that we would require some time.

Your use case seems to be interestring...do you keep the index on the server side and then query on the client side? Also is the same index being used  in a distributive way ?

cheers,
Saurav
Comment 4 jgielstra Mising name CLA 2011-04-12 11:00:00 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Hi,
> > > 
> > > Makes sense.We will work on this as soon as possible.
> > > 
> > > Also could you please let us know about your usage of Query2 ?
> > > such that we keep you updated on changes and updates of Query2.
> > > 
> > > cheers,
> > > Saurav
> > Sure I have a number of Models that I index and query behind a Query Servlet. 
> > I am using Equinox runtime on tomcat via the Equinox Servlet Bridge they
> > provide.  So I have NO ui plugins e.g. org.eclipse.ui and workbench plugins.
> > BTW I logged another defect hacking support for BigInteger and Date ...
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=338164
> 
> We are acting on this bug actively.I think BigInteger support will be also done
> quickly but i am not sure on the date support.Because for that we would require
> some time.
> 
> Your use case seems to be interestring...do you keep the index on the server
> side and then query on the client side? Also is the same index being used  in a
> distributive way ?
> 
> cheers,
> Saurav

Yea doing it simply right now just centralizing the index, no distribution, so the Server is holding the indexes and the client sends queries over. 

On the server there is also an Content Management application that is persisting my models the Content Management app notifies the "Index" when content is added/removed/updated.  The client receives URIs that are relative to the Server.
Comment 5 manasa CLA 2011-04-14 05:22:23 EDT 
Created attachment 193232 [details]
IndexPluginPatch
Comment 6 manasa CLA 2011-04-14 05:23:39 EDT 
Created attachment 193233 [details]
IndexUIPluginPatch
Comment 7 manasa CLA 2011-04-14 05:25:14 EDT 
Hi,

The issue is resolved. UI dependency on non UI index plugin has been removed.
Updated sources are available centrally in CVS.
Also please find the fix patches for the index.ui and index plugins attached.

Regards,
Manasa
Comment 8 saurav sarkar CLA 2011-04-16 07:36:05 EDT 
The patch has been submitted.
Let me know on any further issues.

cheers,
Saurav
Comment 9 saurav sarkar CLA 2011-04-16 07:37:11 EDT 
Closing the bug