Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342291

Summary:

Use the MPart's 'closeable' value if the part is not being rendered in a perspective

Product:

[Eclipse Project] e4

Reporter:

Eric Moffatt <emoffatt>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

tom.schindl

Version:

unspecified

Target Milestone:

4.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Use the part's attribute if it's being rendered directly	none

Description Eric Moffatt

2011-04-08 09:57:11 EDT

We switched over to using a special tag 'IPresentationEngine.NO_CLOSE' on MPlaceholders in order to support the fact that a part can be closeable in one perspective but not in a different one...

...but we forgot to handle the scenario where the part is being used in a simple RCP app.

Comment 1 Eric Moffatt

2011-04-08 10:01:24 EDT

Created attachment 192834 [details]
Use the part's attribute if it's being rendered directly

Comment 2 Eric Moffatt

2011-04-08 10:03:13 EDT

Committed in >20110408. Applied the patch.

Comment 3 Eric Moffatt

2011-04-08 10:03:24 EDT

Marking FIXED.

Comment 4 Eric Moffatt

2011-04-08 10:27:04 EDT

Committed in >20110408. Updated the javadoc on the NO_CLOSE tag to specifically call out the two different mechanisms; use the tag on MPlaceholders when using perspectives, otherwise use the MPart's 'isCloseable' attribute.

Comment 5 Eric Moffatt

2011-04-08 10:32:09 EDT

Tom, I've added bug 342299 to track the issue with the renderer not picking up the state changes after the initial construction...good pickup.