Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342259

Summary: java.nio.charset.UnsupportedCharsetException: latin-1 parsing messages
Product: [Technology] JGit Reporter: Leonard Broman <leonard.broman>
Component: JGitAssignee: Leonard Broman <leonard.broman>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: caniszczyk, sop
Version: unspecified   
Target Milestone: 0.12-M2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch to fix faulty "latin-1" encoding strings none

Description Leonard Broman CLA 2011-04-08 06:32:11 EDT
When a commit message contains
"encoding latin-1" the message parser throws an unsupported encoding exception. 

This bug has been found in the JIRA GIT plugin and I have reported it here: https://studio.plugins.atlassian.com/browse/JGIT-59

It has been reported here as well: http://code.google.com/p/gerrit/issues/detail?id=637
Comment 1 Leonard Broman CLA 2011-04-08 15:19:09 EDT
Created attachment 192874 [details]
Patch to fix faulty "latin-1" encoding strings
Comment 2 Chris Aniszczyk CLA 2011-04-09 18:15:53 EDT
Can you contribute the patch via Gerrit?

Instructions our in our contributor guide...

http://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches
Comment 3 Leonard Broman CLA 2011-04-10 15:11:29 EDT
Done: http://egit.eclipse.org/r/3044
Comment 4 Chris Aniszczyk CLA 2011-04-12 04:29:56 EDT
Fixed with 09be3948cd85171fa3a13d937c7125876e27a273.
Comment 5 Chris Aniszczyk CLA 2011-04-12 08:36:18 EDT
Oh btw Leonard, thanks for the initial patch.

I hope to see more contributions in the future :)
Comment 6 Leonard Broman CLA 2011-04-13 04:14:58 EDT
Thank you very much for including this! It solves some big issues for us.