Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342223

Summary: Build errors in HEAD with new import/export bundle
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: p2Assignee: Pascal Rapicault <pascal>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pascal, tjwatson
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
build.properties patch none

Description DJ Houghton CLA 2011-04-07 17:19:47 EDT 
There is a new p2 import/export bundle in the repository as a result of the work on Bug 282419.

I loaded the project and currently have the following problems:
- 83 Java compiler problems due to access restrictions
- missing about.html/legal files -> this will cause a failure in the releng tests in the build

Currently the project is only in CVS and is not included in a feature so it won't be built. But these problems need to be addressed before the bundle is included in any builds. 

Given that it took us several days to get a clean build after last week's bundle addition, we need to make sure this one goes smoothly. If for nothing else then our sanity. :-)
Comment 1 Thomas Watson CLA 2011-04-11 10:59:29 EDT 
Created attachment 192934 [details]
build.properties patch

The latest N-Build still shows one compile problem for access restrictions.

The bundle still needs about.html/legal files.

I also think the build.properties is missing entries for OSGI-INF and javacTarget for jsr14.  Here is a patch for that.
Comment 2 Thomas Watson CLA 2011-04-11 11:07:03 EDT 
sigh, forget my patch about OSGI-INF.  PDE is just being silly in warning me about that.  Seems the entry is there for the one file in that directory OSGI-INF/importexport.xml
Comment 3 Pascal Rapicault CLA 2011-04-13 09:54:35 EDT 
Fixed.
Only one "error" to report.
Comment 4 Thomas Watson CLA 2011-04-13 10:00:25 EDT 
(In reply to comment #3)
> Fixed.
> Only one "error" to report.


For the error on:

Set<IInstallableUnit> result = new CompoundQueryable<IInstallableUnit>(repos.toArray(new IRepository[repos.size()])).query(QueryUtil.createIUQuery(feature.getIU().getId(), new VersionRange(feature.getIU().getVersion(), true, null, false)), sub2.newChild(100)).toSet();

This is because the method query is inherited through an internal class.  Casting to (IQueryable<IInstallableUnit>) should help.  I think another option is to make CompoundQueryable implement IQueryable directly.
Comment 5 Thomas Watson CLA 2011-04-13 10:30:19 EDT 
FYI, the remaining compile error I mentioned in comment 4 is not an issue at runtime.  Rather it is JDT being too strict I think: bug 122915.