Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342154

Summary:

EMF Facet API should be covered with Unit tests

Product:

z_Archived

Reporter:

Nicolas Guyomar <nicolas.guyomar>

Component:

EMF-Facet

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

emft.facet-inbox, gdupe, nicolas.bros

Version:

unspecified

Flags:

gdupe: juno+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch for Bug 342154 checkstyle	gdupe: iplog+
Patch for Bug 342154 tests part1	gdupe: iplog+
Patch for Bug 342154 part2.patch	none
Patch for Bug 342154 part3	nicolas.bros: iplog+, nicolas.bros: review+
Patch for Bug 342154 API UI Tests	nicolas.bros: iplog+, nicolas.bros: review+

Description Nicolas Guyomar

2011-04-07 09:24:14 EDT

Hi,

Our Table API should be covered by non regression Unit tests.

Regards,
Nicolas Guyomar

Comment 1 Benoit Giuseppin

2011-04-07 11:20:24 EDT

Created attachment 192755 [details]
Patch for Bug 342154 checkstyle

Hi,

This is a patch to add checkstyle to plug-in org.eclipse.emf.facet.widgets.nattable.tests

(a) I, Benoit Giuseppin, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Benoit Giuseppin

Comment 2 Benoit Giuseppin

2011-04-07 11:31:24 EDT

Created attachment 192757 [details]
Patch for Bug 342154 tests part1

Hi,

Please find attached the tests for :
- INatTableWidget.selectAll()
- INatTableWidget.addRows(List<EObject>)
- INatTableWidget.removeLine()
- INatTableWidget.save()

(a) I, Benoit Giuseppin, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Benoit Giuseppin

Comment 3 Gregoire Dupe

2011-04-11 06:03:13 EDT

Comment on attachment 192755 [details]
Patch for Bug 342154 checkstyle

Here is a patch smaller that 250 line (CQ is not required).

I've commited this patch.

Committed revision 508.

Comment 4 Gregoire Dupe

2011-04-11 07:31:29 EDT

Comment on attachment 192757 [details]
Patch for Bug 342154 tests part1

Here is a patch smaller that 250 line (237 lines ; CQ is not required).

I've commited this patch.

Committed revision 509.

Comment 5 Nicolas Guyomar

2011-05-17 09:53:02 EDT

Created attachment 195858 [details]
Patch for Bug 342154 part2.patch

Hi,

To complete what Benoit previously started, here are some additional tests for the EMF Facet table widget.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 6 Nicolas Guyomar

2011-06-17 05:19:56 EDT

Created attachment 198168 [details]
Patch for Bug 342154 part3

Hi,

Please find attached some additional tests to cover EMF Facet API and complete Benoit's previous work.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 7 Nicolas Guyomar

2011-06-17 05:50:37 EDT

Created attachment 198170 [details]
Patch for Bug 342154 API UI Tests

Hi,

Please find attached some new SWT Bot tests for API methods : 
AddQueryColumn()
CopySelectionToClipboard()
IsColumnSelected()
IsSelectedCellEditable()
OpenLoadCustomizationDialog()
OpenLoadFacetDialog()
ActionDelegateRegistration()

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 8 Gregoire Dupe

2011-09-29 15:11:14 EDT

We will only commit these contribution on the head.

Comment 9 Nicolas Bros

2011-09-30 03:25:41 EDT

(In reply to comment #8)
> We will only commit these contribution on the head.
Since the head is always the latest commit, I suppose you mean on the trunk?

Comment 10 Nicolas Bros

2011-09-30 06:21:59 EDT

Comment on attachment 198168 [details]
Patch for Bug 342154 part3

This is a contribution from an employee of Mia-Software, targeting a future
Juno release. The company has signed a Member Committer Agreement. The
contribution does not need a CQ (see bug 322327).

Committed in revision 891.

Comment 11 Nicolas Bros

2011-09-30 10:01:13 EDT

Comment on attachment 198170 [details]
Patch for Bug 342154 API UI Tests

This is a contribution from an employee of Mia-Software, targeting a future
Juno release. The company has signed a Member Committer Agreement. The
contribution does not need a CQ (see bug 322327).

I have made a few additional modifications to this patch to fix race conditions that lead to tests failing randomly.

Committed revision 892.

Comment 12 Nicolas Bros

2011-09-30 10:02:40 EDT

All patches were committed. But I'll leave this bug open until I have seen all these tests pass successfully on Hudson.

Comment 13 Gregoire Dupe

2012-05-23 12:15:57 EDT

This bug can be closed.