Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 342121

Summary:

Unable to see what has focus in parts of Memory Analyzer

Product:

[Tools] MAT

Reporter:

Julie Stalley <julie_stalley>

Component:

GUI

Assignee:

Andrew Johnson <andrew_johnson>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

krum.tsvetkov

Version:

unspecified

Keywords:

accessibility

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

Bug Blocks:

300655

Attachments:

Description	Flags
Screen shot to show the problem	none
Proposed patch	andrew_johnson: iplog-
Proposal for focus box	none
Second proposal for focus box	none

Description Julie Stalley

2011-04-07 05:20:32 EDT

Build Identifier: 

Report views in memory analyzer make it almost impossible to see what has focus. The blue highlighting of the significant lines prevent the user from seeing the focus. 

Reproducible: Always

Steps to Reproduce:
1. Open Memory Analyzer
2. Go to one of the report views where the line is highlighted in blue. 
3. Tab through the items and note that it is difficult to see which line has focus

Comment 1 Julie Stalley

2011-04-07 05:32:37 EDT

Created attachment 192710 [details]
Screen shot to show the problem

Comment 2 Julie Stalley

2011-04-07 05:35:34 EDT

Created attachment 192711 [details]
Proposed patch

To allow focus to be clearly seen, I have changes the style sheet so that the highlighted line is just shown in bold rather than having a blue background.

Comment 3 Krum Tsvetkov

2011-04-29 04:45:20 EDT

Thanks for reporting the problem and sending a patch.
I applied the patch and did some tests locally, however I am not really convinced that it is easier to notice which line is selected with just the text in bold. This impression I had for a "normal" tree where the selected item was somewhere in the middle of the rest.
I saw also some worse cases, where the selected line was the first one. Then it is difficult to distinguish the line from the header of the table.
So, for the moment I wouldn't like to submit the patch. But I'd like to understand the problem a bit better. Is it that when the line is highlighted in blue, then it is difficult to see the dotted rectangle which marks the keyboard focus? If yes, then can we improve this by selecting a lighter or darker color, or in some other way? I've nothing against the bold, but I think it will make it more difficult for many users to easily notice the selection.

Comment 4 Julie Stalley

2011-05-03 06:38:34 EDT

Yes, the problem was reported as "when the line is highlighted in blue, it is difficult to see the dotted rectangle".

Comment 5 Andrew Johnson

2012-11-29 07:05:16 EST

Created attachment 224100 [details]
Proposal for focus box

Comment 6 Andrew Johnson

2012-11-29 07:05:41 EST

I think the focus box is visible on the blue highlighting, particularly when it appears/disappears as the tab key moved the focus, and the blue highlighting is more important than the focus.

If this really is a serious problem we could add this to style.css:

.result tbody tr.selected td a:focus {
    outline-style: dotted;
    outline-color: #000000
}

as shown in the focus1.png attachment.

Comment 7 Andrew Johnson

2013-03-21 08:11:56 EDT

Created attachment 228844 [details]
Second proposal for focus box

Comment 8 Andrew Johnson

2013-03-21 08:15:29 EDT

I've committed a change which adds a thin white dotted box showing focus for a selected item in a table (which has a blue background).

Comment 9 Andrew Johnson

2013-03-21 08:16:45 EDT

Comment on attachment 192711 [details]
Proposed patch

Patch not used.