Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341980

Summary:

The arrows in the Import plug-ins and fragments wizard page could be changed

Product:

[Eclipse Project] PDE

Reporter:

Prakash Rangaraj <prakash>

Component:

Assignee:

Ankur Sharma <ankur_sharma>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

ankur_sharma, curtis.windatt.public, daniel_megert

Version:

3.7

Target Milestone:

3.7 M7

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch	none

Description Prakash Rangaraj

2011-04-06 02:47:01 EDT

In the wizard page, the arrows are denoted by <-- and -->, which are not looking good. Also the UI guide lines hints on using only < and > See: http://wiki.eclipse.org/User_Interface_Guidelines#Multiple_Item_Selection

Now Platform UI has a similar widget Configure Columns dialog ( Problems View-> Columns... ) We use < and >. It would be good if PDE switches to this format to have consistency in SDK

Comment 1 Curtis Windatt

2011-04-06 10:05:19 EDT

We'll fix this in M7 or RC1

Comment 2 Ankur Sharma

2011-04-06 11:16:09 EDT

Created attachment 192652 [details]
Patch

Comment 3 Ankur Sharma

2011-04-06 11:18:16 EDT

Fixed in HEAD

Comment 4 Curtis Windatt

2011-04-06 11:34:05 EDT

The fix is acceptable, but we could consider going one step further.  The guildelines suggest that > < >> << be used instead of text.  Obviously we have some additional options that might not fit right.  Just something to consider.

Comment 5 Prakash Rangaraj

2011-04-06 12:51:36 EDT

(In reply to comment #4)
> The fix is acceptable, but we could consider going one step further.  The
> guildelines suggest that > < >> << be used instead of text.  Obviously we have
> some additional options that might not fit right.  Just something to consider.

    I don't agree with the Guidelines that aspect. No other places in the SDK has a push button without any text. This is also an issue with accessibility, as it will be confusing for those who use the screen readers. It will simply read out 'Greater than' and 'less than'.

    But I agree that we could use Add All >> and << Remove All (two symbols for the "Move All" buttons)

Comment 6 Dani Megert

2011-04-12 03:40:50 EDT

(In reply to comment #0)
> In the wizard page, the arrows are denoted by <-- and -->, which are not
> looking good. Also the UI guide lines hints on using only < and > See:
> http://wiki.eclipse.org/User_Interface_Guidelines#Multiple_Item_Selection
> 
That's outdated. The Microsoft UX guidelines for Windows 7 and Vista specify to use '->' and '<-' together with text (see page 109).

> Now Platform UI has a similar widget Configure Columns dialog ( Problems 
> View-> Columns... ) We use < and >. It would be good if PDE switches to this 
> format to have consistency in SDK 
Nice try ;-) The PDE dialog was first and there are several other places in the SDK where "-->" and "<--" are used. The polish bug 231081 also requests to change it in the 'Configure Columns'. Having said that, I agree that "->" and "<-" look better and follow the Win 7 UX guidelines. I've fixed the places in the SDK.

I also agree that the guidelines are wrong regarding the text. It is needed for accessibility and makes it easier to see what the buttons do.

I've replaced the "==" with "-".