Bugzilla – Full Text Bug Listing
| Summary: | EVL Ant task does not honor failOnWarnings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Epsilon | Reporter: | Antonio Garcia-Dominguez <agarcdomi> | ||||
| Component: | Core | Assignee: | Antonio Garcia-Dominguez <agarcdomi> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | dkolovos | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | interim | ||||||
| Attachments: |
|
||||||
Oops, please disregard the new boolean field "warnings". The rest of the code is fine. In the patch code, there's a call to fail(message, null). In my version of the code fail() only receives one argument of type String. Have you perhaps also modified the EpsilonTask? That would be me. I need fail to receive the exception as well, so I can put a proper Java stack trace in the XML results of an EUnit test suite. OK. I've removed the second argument for now and will leave it to you to integrate the remaining changes when your committer account is active if that's OK. OK. I already did the paperwork: I'm waiting for them to send me the credentials. Integrated after committing the rest of the EUnit code into SVN. Fixed in 0.9.1 |
Created attachment 192574 [details] Patch which fixes the issue If an EVL script only reports warnings, failOnErrors is set to true and failOnWarnings is set to false, the build fails, and it shouldn't. This is because of the following code in EvlTask: if (errors > 0 || warnings > 0) { fail((errors + " error(s) and " + warnings + " warning(s) found during validation"), null); } As you can see, it always fails: it doesn't tell apart the case when only warnings are reported. I've attached a patch which fixes this issue.