Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341900

Summary:

Metatype must support optional 'pid' attribute on <Designate> element.

Product:

[Eclipse Project] Equinox

Reporter:

John Ross <jwross>

Component:

Compendium

Assignee:

John Ross <jwross>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

tjwatson

Version:

unspecified

Target Milestone:

3.7 M7

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed Patch	tjwatson: iplog+

Description John Ross

2011-04-05 09:15:58 EDT

Build Identifier: 

The 4.3 compendium makes the 'pid' attribute on the <Designate> element optional instead of required. The implementation needs to be updated to not automatically reject XML that omits this attribute. The rule is the <Designate> element must have either the 'pid' or 'factoryPid' attribute. Both are also allowed to be present. If both are present, the 'factoryPid' takes precedence and the 'pid' is ignored.

Reproducible: Always

Comment 1 John Ross

2011-04-05 09:17:28 EDT

See https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1852 and https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1951.

Comment 2 John Ross

2011-04-05 15:29:01 EDT

Created attachment 192592 [details]
Proposed Patch

This patch takes into account the now optional 'pid' attribute on the <Designate> element. Either 'pid' or 'factoryPid' must be present. If neither are specified, a (new) error message is logged and the entire XML file rejected. If 'factoryPid' is present, 'pid' (present or absent) is ignored entirely.

Comment 3 Thomas Watson

2011-04-06 12:32:18 EDT

Thanks John!  Patch released.