Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341885

Summary:

[EditorReference] Pinned editor image overlay is not displayed

Product:

[RT] RAP

Reporter:

Kaloyan Radev <k.radev>

Component:

Workbench

Assignee:

Project Inbox <rap-inbox>

Status:

ASSIGNED ---

QA Contact:

Severity:

normal

Priority:

CC:

k.radev

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
proposed patch based on diffs from RAP 1.3.2	none
Clean patch	none

Description Kaloyan Radev

2011-04-05 06:36:31 EDT

Build Identifier: RAP 1.3.2, RAP 1.4.M6

Pinned editor image overlay is not displayed and the comment in the source code states that OverlayImage is (still) not available, which is perfectly correct. Anyway the org.eclipse.jface.viewers.DecorationOverlayIcon could do the the same job.

Reproducible: Always

Steps to Reproduce:
1. Allow editor reusage with 

    IPreferenceStore prefStore = WorkbenchPlugin.getDefault().getPreferenceStore();
    prefStore.setValue(IPreferenceConstants.REUSE_EDITORS, 1);
    prefStore.setValue(IPreferenceConstants.REUSE_EDITORS_BOOLEAN, true);

2. Pin manually an editor.
3. The editor part image is not changed.

Comment 1 Kaloyan Radev

2011-04-05 06:38:46 EDT

Created attachment 192538 [details]
proposed patch based on diffs from RAP 1.3.2

Comment 2 Ivan Furnadjiev

2011-04-05 09:01:52 EDT

Created attachment 192552 [details]
Clean patch

This is the same patch created with Eclipse against CVS HEAD.