Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341858

Summary:	Diagram connection binding id specification is confusing
Product:	z_Archived	Reporter:	Konstantin Komissarchik <konstantin>
Component:	Sapphire	Assignee:	Shenxue Zhou <shenxue.zhou>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Konstantin Komissarchik

2011-04-05 00:43:22 EDT

IDiagramConnectionBindingDef reuses Id property from ISapphirePartDef to mean the id of the connection it is the binding for. This is confusing. There should be a separate ConnectionId property that binds to "connection-id" element. IDiagramConnectionBindingDef should not extend ISapphirePartDef. The binding specification is not a part.

Comment 1 Konstantin Komissarchik

2011-04-05 00:43:59 EDT

Make sure to update the sdef editor after making this change.

Comment 2 Shenxue Zhou

2011-04-07 17:19:38 EDT

Fix checked in.

Note: IDiagramConnectionDef is the visual definition of a connection while IDiagramConnectionBindingDef is tied with diagram connection parts. So IDiagramConnectionBdiningDef needs to extend ISapphirePartDef. IDiagramConnectionDef does not. I've corrected that as well.

Comment 3 Konstantin Komissarchik

2011-04-07 19:06:49 EDT

> Note: IDiagramConnectionDef is the visual definition of a connection while
> IDiagramConnectionBindingDef is tied with diagram connection parts. So
> IDiagramConnectionBdiningDef needs to extend ISapphirePartDef.
> IDiagramConnectionDef does not. I've corrected that as well.

That's exactly backwards. ISapphirePartDef has the properties for defining actions, hints, etc. Those settings are necessary on the connection, not the binding.

Comment 4 Shenxue Zhou

2011-04-08 15:45:35 EDT

You're right the connection definition should extend ISapphirePartDef so it can define actions, action handlers etc. Connection binding def should only concern about how a connection is tied with model elements/properties.

Just checked in the fix and hopefully I got it right this time...

Comment 5 Konstantin Komissarchik

2011-04-13 15:33:59 EDT

Verified. Closing.