Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341848

Summary:	disabled semanticHighlighting not completely restored during startup
Product:	z_Archived	Reporter:	Dan <dwilks>
Component:	PDT	Assignee:	PHP UI <php.ui-inbox>
Status:	CLOSED FIXED	QA Contact:	Ilina Stefanova <ilina.s>
Severity:	normal
Priority:	P1	CC:	ilina.s, zhaozhongwei
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Dan

2011-04-04 17:24:58 EDT

Build Identifier: 20110218-0911

After disabling all syntax coloring it's back after shutting down and starting eclipse back up.  The preferences dialog correctly shows that the coloring is disabled but the files in the editor are still being colored (and slow).

Reproducible: Always

Steps to Reproduce:
1. Preferences / PHP / Editor / Syntax Coloring
2. Walk down the list of Syntax Elements and uncheck Enabled on all of them
3. Verify that your editors are all nice and simple with no syntax coloring of any kind.  Open new editors and verify the same.
4. Quit Eclipse
5. Verify that they're all disabled in the preferences file ($workspace/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.php.ui.prefs)semanticHighlighting.*.enabled=false.
6. Start up eclipse, open the previous workspace
7. Open preferences, verify that all the syntax coloring is still not enabled
8. Open some php files (or look at the ones that were re-opened).
Result: They're all nice and pretty with full syntax coloring.
Expected: Them to be all plain and monochrome.

Workaround: You have to restore the default prefs and apply and then re-disable them.

Why disable syntax coloring?  Performance on large files.  See http://onestoryeveryday.com/eclipse-pdt-helios-fix-slow-editor-when-opening-large-php-files.html as an example.

org.eclipse.php.core: 2.2.1.v20101001-2300
org.eclipse.php.ui: 2.2.1.v20101001-2300

Comment 1 Dan

2011-04-04 19:11:32 EDT

After playing around with this some more I noticed that the disabled syntax coloring sometimes wouldn't always get picked up on new files that I opened even within the session in which I disabled syntax coloring.  They would open fully colored and fully slow (if they were large).

In desperation it I enabled all the coloring options and set them all to black on white with no decorations (bold, italic, ...).  Surprisingly the editor is as blindingly fast as if I had all the syntax colorings disabled.  And the colors are being preserved across restarts.

This hints that the large-file performance issue is not in syntax processing but it maybe somewhere in the rendering?

Comment 2 Zhongwei Zhao

2011-05-12 04:11:04 EDT

fixed in head

Comment 3 Ilina Stefanova

2011-08-02 02:33:07 EDT

Still reproducible after switching workspace and restarting. Reopening.

Comment 4 Zhongwei Zhao

2011-08-08 00:48:01 EDT

hi,

I think you should not switch workspace to test this bug,the preferences are different for different workspaces.

Comment 5 Ilina Stefanova

2011-10-18 05:04:44 EDT

OK, I agree the switch workspace is not proper scenario and each has it's own preferences, but the defect is reproducible without even restart the workspece. Refresh does not work too. Reopening.

Comment 6 Zhongwei Zhao

2011-11-22 06:29:15 EST

fixed

Comment 7 Ilina Stefanova

2012-07-05 02:37:29 EDT

Verified. Closing