Bugzilla – Full Text Bug Listing
| Summary: | Strings on the Traditional Mmemory Rendering preferences page unexternalized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Kit Lo <kitlo> | ||||
| Component: | cdt-memory | Assignee: | Vivian Kong <vivkong> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Ted Williams <ted> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | cdtdoug, pawel.1.piech, st.laurent, vivkong | ||||
| Version: | 8.0 | ||||||
| Target Milestone: | 8.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
The Traditional [memory] Renderer externalizes strings in the file TraditionalRendering_messages.properties (granted, this defies the convention of naming the file "messages.properties"). And, just to make double sure, I skimmed the code to make sure that any hard-coded strings are not exposed via the UI. My question for you is: Were you searching through all of CDT for only "messages.properties"? Or did you look at "*.properties"? I saw the TraditionalRendering_messages.properties file. However, I don't see the strings from the preferences page (for example: "Use Global Te&xt Color") in the file. Ah, right you are. Seems that (A) I did not read your initial comment close enough and (B) my skimming of the source was inadequate. My apologies. The TraditionalRenderingPreferencePage class does indeed have some hard-coded strings that are exposed via the UI. I did a more careful examination of the 129 strings that matched by regEx search and it looks to me that the only strings not externalized are in TraditionalRenderingPreferencePage, which you noted originally. It would probably be a good idea to add these to TraditionalRendering_messages.properties. Fixed in HEAD *** cdt cvs genie on behalf of vkong *** Bug 341730 Strings on the Traditional Memory Rendering preferences page not externalized [*] TraditionalRenderingPreferencePage.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TraditionalRenderingPreferencePage.java?root=Tools_Project&r1=1.1&r2=1.2 [*] TraditionalRendering_messages.properties 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TraditionalRendering_messages.properties?root=Tools_Project&r1=1.4&r2=1.5 |
Created attachment 192428 [details] Traditional Memory Rendering preferences I cannot locate the strings on the Traditional Mmemory Rendering preferences page in any of the .properties files in cdt-memory plugins. They may be hard-coded in the plugins. I couldn't find any of the source plugins for cdt-memory to verify. That could be a separate problem.