Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341729

Summary:

Undo in properties view without effect

Product:

z_Archived

Reporter:

Tobias Liefke <eclipse>

Component:

BPEL

Assignee:

BPEL UI Inbox <bpel.ui-inbox>

Status:

NEW ---

QA Contact:

Severity:

major

Priority:

CC:

bbrodt

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch for Undo/Redo in properties view	none

Description Tobias Liefke

2011-04-03 15:50:30 EDT

If the properties view is focused and Edit->Undo is selected (e.g after changing the name of an activity in the view, but other properties are affected, too), that command has no effect.

Comment 1 Tobias Liefke

2011-04-05 02:51:43 EDT

Created attachment 192523 [details]
Patch for Undo/Redo in properties view

As far as I can see, it would be the best solution to let the "AutoUndoCommand" not only record any changes with the undo manager of the DOM model, but also handle the undo/redo calls. The attached patch does exactly that.

Comment 2 Robert Brodt

2011-04-08 12:23:15 EDT

This is a good start, but it has undesirable side-effects ;)

1. Try adding a new activity from the toolpalette, then focus on the property view and ^Z - the activity is removed from the design canvas but the property view still shows the properties for the (now missing!) activity.
2. Add a fault handler, change something in the property view for the Catch, then ^Z several times - NPE
3. add an Assign and configure some assignment operations, then ^Z several times - the undo should update the widgets as the undostack is unloaded, but alas...

Bottom line is that undo/redo still needs a LOT of work :( and this quick fix introduces more problems than it's worth. This is a big task IMO and needs careful investigation, but you are welcome to give it a try ;)