Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341725

Summary: Automatic discovery of Jenkins services may be triggered on already configured services
Product: z_Archived Reporter: Torkild Resheim <torkildr>
Component: MylynAssignee: Torkild Resheim <torkildr>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bugs.eclipse.org, mjmeijer
Version: unspecified   
Target Milestone: 0.9   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
fix
none
mylyn/context/zip none

Description Torkild Resheim CLA 2011-04-03 14:46:26 EDT
Automatic discovery of Hudson/Jenkins servers may be triggered on already configured servers if the URL of the discovered service is different. According to documentation Hudson/Jenkins replies to UDP broadcast packets with the following data:

<hudson>
  <version>1.354</version><!-- version of the Hudson -->
  <url>http://server/hudson/</url><!-- the top page of the Hudson -->
  <slave-port>12345</slave-port><!-- TCP port number for slaves and CLIs to connect to -->
  ... more elements may appear here ...
</hudson>

The only part useful for identification is the URL. As this value is specified in the Hudson configuration it may be just one of the possible URLs one can use to reach the service.

See also bug 340986 where this problem was initially discussed.
Comment 1 maarten meijer CLA 2011-04-03 15:02:06 EDT
I recommend also open a issue at jenkins and hudson stating this particular issue.
Then we can finally discover which of the two projects is most responsive...
Comment 2 Torkild Resheim CLA 2011-04-03 15:42:16 EDT
I agree :-)  Just wanted to first check that we indeed are limited to the documented properties. Using the latest Hudson release I can confirm that we are.
Comment 3 Torkild Resheim CLA 2011-04-03 16:09:20 EDT
Added bug reports to Hudson and Jenkins:
* https://issues.jenkins-ci.org/browse/JENKINS-9230
* http://issues.hudson-ci.org/browse/HUDSON-8800
Comment 4 Torkild Resheim CLA 2011-04-21 16:03:41 EDT
Got a little impatient so I blogged about this issue. It took about one hour before the Jenkins team marked their issue as fixed! Thanks. I'll do the Eclipse work ASAP.
Comment 5 Torkild Resheim CLA 2011-04-28 04:33:25 EDT
Build #733 of Jenkins (trunk) contains this proposed change and should be suitable for testing.
Comment 6 Torkild Resheim CLA 2011-04-30 16:34:32 EDT
I've started on implementing a fix but got stumped by a problem generating code from the EMF model. http://www.eclipse.org/forums/index.php?t=tree&goto=667665&S=96a2a9fc3d7f9bfeb35a00f389b46aff#msg_667665
Comment 7 Torkild Resheim CLA 2011-08-02 09:26:52 EDT
(In reply to comment #6)
> I've started on implementing a fix but got stumped by a problem generating code
> from the EMF model.
Decided against adding an extra ID property to BuildServer. Will use the ID in RepositoryLocation instead.
Comment 8 Torkild Resheim CLA 2011-08-03 04:14:36 EDT
Created attachment 200778 [details]
fix

Uses unique identifier announced by server if available ("server-id"). Will not announce discovered server if the id is already in the repository.
Comment 9 Torkild Resheim CLA 2011-08-03 04:14:39 EDT
Created attachment 200779 [details]
mylyn/context/zip
Comment 10 Torkild Resheim CLA 2011-08-03 04:24:59 EDT
The fix is in place for Jenkins (tested with build 1.424). There appears to be no activity related to this issue on the Hudson project. So I'm marking this as fixed and create a new report for Hudson (bug 353705).