Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 34168

Summary: [rulers] Active area of problem markers too small
Product: [Eclipse Project] JDT Reporter: Ron Baldwin <bogofilter+eclipse.org>
Component: TextAssignee: JDT-Text-Inbox <jdt-text-inbox>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, gabriele.garuglieri, jeffmcaffer, Jim.Adams
Version: 3.0   
Target Milestone: 3.4   
Hardware: PC   
OS: Windows All   
Whiteboard:
Attachments:
Description Flags
marker screenshot none

Description Ron Baldwin CLA 2003-03-07 19:40:17 EST
The active area of the rectangular problem markers on the right side of the
editor is too small.  The mouse pointer only turns to a hand on the top 2 pixels
of the marker (the marker is 5 pixels high).  This makes it pretty hard to click
on the markers.
Comment 1 Gabriele Garuglieri CLA 2004-06-08 05:28:56 EDT
In a perfect world, where no dust exists, would be easy to roll the mouse ball
to keep the pointer within two pixels long enough to click on markers, but in
the world where i live, where mouse balls love picking up any dust particle
laying in their path, this become a real Zen exercise.
Now, without kidding, please could you increase the markers clickable area for 3.0?
Gabriele.
Comment 2 Ron Baldwin CLA 2004-06-08 10:05:02 EDT
In 3.0 RC1, the entire height of the problem marker is clickable.
Comment 3 Gabriele Garuglieri CLA 2004-06-08 10:49:49 EDT
Sorry to have to contraddict you, but i'm working with 3.0RC1 and, unless i'm
doing a giant mistake, i see that with M9 the clickable area looks to be larger,
may be 3 pixels, and now with RC1 is back to same as before, 2 pixels.
If i'm doing something odd, please advice, otherwise i'll be glad if you could
reopen this bug to have a comment from someone in eclipse group.
Thanks,  Gabriele.
Comment 4 Ron Baldwin CLA 2004-06-08 10:58:55 EDT
I'll reopen on your behalf.  However, I just double checked that I am indeed
running RC1, and for me, the problem markers on the right side of the edit
window are clickable from their top pixel to their bottom pixel.
Comment 5 Gabriele Garuglieri CLA 2004-06-09 03:40:24 EDT
I tried again with a clean installation of RC1 and i can confirm that the active
area of all the markers is only two pixels height.
May be the fact that you are running on Win 2K and i'm running with XP Pro is
causing the different behaviour.
Comment 6 Ron Baldwin CLA 2004-06-09 09:55:02 EDT
Well, I was running Win2k when this bug was opened... :-)

I am now running WinXP Pro, and the clickable area for me is definitely greater
than 2 pixels.  However, the clickable area still seems to be excluding the
bottom pixel of the marker.

In addition, if there is a problem on the last line of a file, the bottom of the
problem marker gets cut off.  In general, there seems to be some miscalculations
going on in the right margin of the editor.

--> Windows All, since this obviously affect more than one version of Windows.
Comment 7 Gabriele Garuglieri CLA 2004-06-15 05:48:43 EDT
Well Ron, i installed this morning RC2 and i can confirm that with it the active
area is now the entire marker but its bottom pixels row.
Still not perfect :) but much better than before.
Feel free to close the bug at your wish.

Thanks Gabriele.
Comment 8 Ron Baldwin CLA 2004-06-15 10:07:08 EDT
It is certainly improved, but since it's not perfect I'm leaving open to correct
the bottom pixel of marker and marker on the bottom line of editor issues.
Comment 9 Gabriele Garuglieri CLA 2004-06-17 02:43:55 EDT
No, no, no, definitely either i'm i an unlucky boy or there's something wrong
somewhere.
In my last update i wrote that with RC2 the active area was the entire marker
but its bottom pixels row.
Well, it was so until i stopped and restarted eclipse.
Now i'm back again in the situation where only the upper two pixels rows are
sensible. What can change stopping and restarting eclipse?
Pls, can someone from eclipse team comment on this?
Thanks,  Gabriele.
Comment 10 Dani Megert CLA 2004-06-17 03:00:55 EDT
besided exit and restart: did you eventually change the font?
Comment 11 Gabriele Garuglieri CLA 2004-06-17 03:19:58 EDT
No, all factory settings.
I just stopped and restarted due to the occurrence of bug 67435 / bug 63635.
Comment 12 Gabriele Garuglieri CLA 2004-06-17 05:33:57 EDT
This thing is becoming to make me crazy.
I have discovered that on some files the active area for the markers is only the
top two pixels rows, on some files the active area extends for the whole marker
and on some files the actve area extends well below the marker where there's
nothing.
I know, i know you don't believe me so i'll attach a portion of a screen shot
where you can see what i'm talking about.
Comment 13 Gabriele Garuglieri CLA 2004-06-17 05:42:14 EDT
Created attachment 12369 [details]
marker screenshot

If you look at the image, you'll see a black cross under the marker. That's
where the tip of the mouse pointer was when it changed in a hand and the yellow
label (how is it called?) popped out.
If you look where normally the top line of that label is, related to the
pointer tip, when it appears, you can see i'm not fooling you.
Comment 14 Dani Megert CLA 2007-06-25 05:59:34 EDT
See also bug 163769.
Comment 15 Dani Megert CLA 2007-06-25 05:59:46 EDT
*** Bug 60943 has been marked as a duplicate of this bug. ***
Comment 16 Dani Megert CLA 2007-06-25 06:01:44 EDT
*** Bug 194078 has been marked as a duplicate of this bug. ***
Comment 17 Jeff McAffer CLA 2007-06-25 08:52:49 EDT
so can we just remove the idea of targetting the marker area and say that the right ruler is just a "quick goto area"?  Seems it would simplify the code and the user experience.  A rare opportunity?!
Comment 18 Dani Megert CLA 2007-06-25 08:58:45 EDT
Since day one people got used to click on those things to go directly to the corresponding annotation in the code. I use that quite often (several times a day). If we change this to only go to the line it would be a pain and lost function for those users.
Comment 19 Jeff McAffer CLA 2007-06-26 08:52:35 EDT
I didnt even know it did anything different than just go to the line.  does it highlight the problem/marked area?  I try to use the feature but don't care if it goes to the exact line as long as the line corresponding to the area I clicked is in the editor window.  Right now it is immensely frustrating to hit the target area and in the end I usually end up manually scrolling until the thumb is next to the marker in the ruler.

So how about a compromise.  Make the target area of the box a bit bigger and thus easier to hit.  Alos, make it such that when you miss the target you still scroll to the line corresponding to where you did click.  Users are better off without loss of function.  If they missed they have to click again and they still can.  If they are like me, they don't care as long as they got close and they don't have to click again.  Win/win!
Comment 20 Dani Megert CLA 2007-06-26 08:56:26 EDT
>does it highlight the problem/marked area?
Yes.

The plan is to fix it as described along with some other [rulers] marked bugs that I tagged for 3.4.
Comment 21 Jeff McAffer CLA 2007-06-26 09:10:51 EDT
great.  thanks
Comment 22 Dani Megert CLA 2008-04-24 06:56:12 EDT

*** This bug has been marked as a duplicate of bug 163769 ***