Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341503

Summary:	Compact list property editor add hyperlink doesn't show disabled state
Product:	z_Archived	Reporter:	Konstantin Komissarchik <konstantin>
Component:	Sapphire	Assignee:	Ling Hao <ling.hao>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Konstantin Komissarchik

2011-03-31 11:18:41 EDT

The add list item hyperlink at the bottom of the compact list property editor does not show disabled state when the property is disabled. It remains blue in color.

Comment 1 Ling Hao

2011-03-31 18:41:19 EDT

This bug is in the org.eclipse.ui.forms.widgets.FormText and the fix is not trivial. I vote we set this to a lower priority until we have a real test case that requires a disabled compact list.

Comment 2 Konstantin Komissarchik

2011-03-31 20:56:24 EDT

I am fine with dropping the priority on this for now, but could you go a bit into the detail on the technical issues involved in fixing this? I am assuming it isn't actually using FormText, but rather our forked SapphireFormText copy that we can modify at will.

Comment 3 Konstantin Komissarchik

2011-06-03 16:53:48 EDT

Could you answer my question regarding the implementation difficulty on this?

Comment 4 Ling Hao

2011-06-03 17:05:53 EDT

Not trivial, but should be doable.

Comment 5 Konstantin Komissarchik

2011-06-03 19:40:41 EDT

Ok. Please take a look for 0.3. We don't have a lot of time left in the release and it would be great to wrap this editor up completely.

Comment 6 Ling Hao

2011-06-09 19:48:15 EDT

Resolved by drawing in gray. It looks a little different under windows7, probably accented by the fact that the different fonts. There are no generic way in Eclipse to get the disabled color - see bug:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=22782 (Need API to draw disabled text in native platform way)

Comment 7 Konstantin Komissarchik

2011-06-10 13:15:18 EDT

Looks good enough to me. At least on Win7. Verified with the gallery sample. Closing.