Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341453

Summary: Unable to read the Getting Started dialog correctly with JAWS
Product: [Tools] MAT Reporter: Julie Stalley <julie_stalley>
Component: GUIAssignee: Krum Tsvetkov <krum.tsvetkov>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: andrew_johnson
Version: unspecifiedKeywords: accessibility
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 300655    
Attachments:
Description Flags
Proposed patch krum.tsvetkov: iplog+

Description Julie Stalley CLA 2011-03-31 05:13:17 EDT
Build Identifier: 

The main problem with this dialog is that JAWS reads the first radio button as '1 of 1' so the user is unaware that there are 2 other options on the page. We need the button to be read as '1 of 3' so the user can change the selection

Reproducible: Always

Steps to Reproduce:
1. Start JAWS and then start Memory Analyzer
2. Open a heap dump
3. Listen to JAWS describe the getting started dialog
Comment 1 Julie Stalley CLA 2011-03-31 05:20:24 EDT
Created attachment 192255 [details]
Proposed patch

I have had to change the layout of the dialog to use a FormLayout so that JAWS can recognise the button's as being in a group.  Have also overridden the accessible names of the radio buttons and labels so that the user gets the orect things read out
Comment 2 Julie Stalley CLA 2011-03-31 06:25:19 EDT
(In reply to comment #1)
> Created attachment 192255 [details]
> Proposed patch
> 
> I have had to change the layout of the dialog to use a FormLayout so that JAWS
> can recognise the button's as being in a group.  Have also overridden the
> accessible names of the radio buttons and labels so that the user gets the
> correct things read out

I have also formatted the code to comply with the project standard
Comment 3 Andrew Johnson CLA 2011-04-04 10:29:54 EDT
Thanks for the patch.

I'm not sure if building text by taking a title and adding a full stop, then adding the description is safe for languages such as Japanese.
Comment 4 Julie Stalley CLA 2011-04-07 05:37:35 EDT
(In reply to comment #3)
> Thanks for the patch.
> 
> I'm not sure if building text by taking a title and adding a full stop, then
> adding the description is safe for languages such as Japanese.

Putting these two items together does not change the meaning so this should not be a problem for translation.
Comment 5 Krum Tsvetkov CLA 2011-04-29 06:22:09 EDT
Thanks for the patch! I did some testing and think the changes are fine.

I'd like to submit the patch. To fulfill the process requirements, please could you confirm for the patch:
1.that you wrote 100% of the code
2.that you are authorized to contribute it
3.that is is submitted under the EPL.
Comment 6 Krum Tsvetkov CLA 2011-05-02 05:35:20 EDT
Comment on attachment 192255 [details]
Proposed patch

Checked in with revision 1108.
I adjusted the Copyright header in the file.
Comment 7 Krum Tsvetkov CLA 2011-05-02 05:36:32 EDT
Closing the bug as the patch solves the problem.
Comment 8 Julie Stalley CLA 2011-05-03 05:48:42 EDT
I confirm that I wrote 100% of the code, that I am authorized to contribute it and that it is submitted under the EPL.
Comment 9 Andrew Johnson CLA 2011-05-03 10:48:57 EDT
Bug 282032 lists a similar problem.