Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341390

Summary: Upgrade AspectJ to 1.6.11 or later
Product: [RT] Virgo Reporter: Glyn Normington <glyn.normington>
Component: runtimeAssignee: Project Inbox <virgo-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 CC: aclement, andrew.eisenberg, eclipse
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
URL: http://www.eclipse.org/forums/index.php?t=msg&th=206900&start=0&S=14d2e705295a369cd4429cc149fbcb16
Whiteboard:
Bug Depends on: 341130    
Bug Blocks: 327204    

Description Glyn Normington CLA 2011-03-30 12:10:16 EDT 

    


    


      



        
          Comment 1
        

        
          Andrew Clement CLA

        

        
        

        
          2011-03-30 12:31:22 EDT
        

      






Glyn - there is an AspectJ bug I raised against 1.6.11 that came about due to me investigating a problem Steve raised a while back.  Steves issue was bug 292239 - that is now fixed, but whilst investigating it revealed an inadvertent change in matching that came about due to a large scale refactoring/performance pass in AspectJ 1.6.8.  The new issue is bug 341130.  I don't know whether you are still relying on the matching occurring as Steves example showed in 292239 but if you are, there may be issues with you jumping to 1.6.11.

I haven't yet decided if the change in matching is a regression or was just me closing an accidental hole - the behaviour isn't very well spec'd for the scenario.

Anyway, I just mention this to give you a heads up - a lot changed around the 1.6.8 timeframe (driven by a requirement for performance/memory improvements), but I'm sure your tests will pick up on anything weird.

    


    


      



        
          Comment 2
        

        
          Glyn Normington CLA

        

        
        

        
          2011-03-31 04:32:30 EDT
        

      






Hi Andy

Thanks for pointing that out. As the linked forum thread shows, users can successfully upgrade Virgo to AspectJ 1.6.10 on their own, so this enhancement can be treated as low priority.

I'm not convinced our tests cover exception throwing from JMX invocations well if at all, so let's hold off implementing this enhancement until bug 341130 is fixed (assuming that will allow us to switch from the workaround to Steve's example code attached to bug 292339).

Regards,
Glyn

    


    


      



        
          Comment 3
        

        
          Chris Frost CLA

        

        
        

        
          2012-05-04 09:35:57 EDT
        

      






This has happened now, we have been on aspectJ 1.6.12 for a few months.