Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341369

Summary:	CompositeEditorFactoriesRegistry : inverted type comparison
Product:	z_Archived	Reporter:	Nicolas Bros <nicolas.bros>
Component:	EMF-Facet	Assignee:	Nicolas Bros <nicolas.bros>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	emft.facet-inbox, gdupe
Version:	unspecified	Flags:	nicolas.bros: indigo+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Nicolas Bros

2011-03-30 10:27:42 EDT

In CompositeEditorFactoriesRegistry#getCompositeEditorFactory, the factory checks if the type is handled by a given cell editor. But it doesn't work for subtypes.

The comparison is currently:
objectType.isAssignableFrom(handledType)
It should be instead:
handledType.isAssignableFrom(objectType)

Comment 1 Nicolas Bros

2011-03-30 10:28:59 EDT

Fixed in revision 477.

Comment 2 Gregoire Dupe

2011-06-08 10:53:46 EDT

I assume this bug can be closed, but a unit test would have been welcomed to help the reviewer to check the correctness of the fix.