Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341303

Summary: Add limited support for Project classpath entries in classpath containers
Product: [WebTools] WTP Java EE Tools Reporter: Roberto Sanchez Herrera <shr31223>
Component: jst.j2eeAssignee: Roberto Sanchez Herrera <shr31223>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc
Version: 3.2.3Flags: cbridgha: review+
ccc: review+
Target Milestone: 3.2.4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed patch none

Description Roberto Sanchez Herrera CLA 2011-03-29 23:33:49 EDT 
Build Identifier: WTP 3.2.3

This bug is to add limited support for project classpath entries included in classpath containers.

This support would allow classpath containers tagged as classpath dependencies  to include project classpath entries (only faceted projects)


Reproducible: Always
Comment 1 Roberto Sanchez Herrera CLA 2011-03-29 23:43:20 EDT 
Created attachment 192155 [details]
Proposed patch

Summary of the changes:

- AddClasspathLibReferencesParticipant.java: Add logic to gather project classpath entries provided by child module to parent.
- J2EEModuleVirtualComponent.java: Create virtual references to project classpath entries
- ClasspathDependencyValidator.java: Do not signal an error when adding a project classpath entry that refers to a faceted project
- ClasspathDependencyUtil.java: Include project classpath entries
- IFlattenParticipant.java: Add method to get child modules that participant thinks should be added to virtual component
- AbstractFlattenParticipant.java: Default implementation for new method
- FlatVirtualComponent.java: Include child modules from participants
Comment 2 Carl Anderson CLA 2011-03-30 18:33:57 EDT 
I ran the entire Java EE JUnit bucket against this patch.

I believe that this adds in minimal, required support for this scenario- something that many adopters and users are asking for.

I do have concerns about this behavioral change in a maintenance stream, but weighing that concern against the desires of the community and the minimal nature of this change, I agree to its inclusion.
Comment 3 Chuck Bridgham CLA 2011-03-30 21:02:16 EDT 
I also have investigated these changes, and have run tests.  The behavior change is simply "including" referenced projects from within a mapped classpath container, where they were ignored before.  This is an important incremental step in this maintenance release, and will revisit for inclusion in later releases.
Comment 4 Carl Anderson CLA 2011-04-07 00:09:38 EDT 
Committed to R3_2_maintenance and HEAD for WTP 3.2.4 and WTP 3.3 M7