Bugzilla – Full Text Bug Listing
| Summary: | Error message when opcontrol script returns an error needs improvement | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Corey Ashford <cjashfor> | ||||||
| Component: | LinuxTools | Assignee: | OProfile Inbox <linux.oprofile-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | kksebasti, overholt | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Thanks, Corey. I'd prefer something more generic than "/opt/at4.0/bin/opcontrol", though :) Perhaps /path/to/opcontrol? Created attachment 192210 [details]
Improves error message when opcontrol returns a non-zero status
Thanks for catching that error. I had posted the wrong version of the patch to this bugzilla (but the right one to the mailing list). I've posted a new version with path corrected, and obsoleted the old one. Thanks, Corey. I've applied it and pushed. In the future, it would be nice if your patches could be applied with EGit but I'll take quality patches over having to use 'git am' :) Applied in 0616ff686e4dc70af38d70543b7bf98a7a3bb460. I'm certainly willing to do whatever it takes to submit future patches in whatever form can be used by Egit. For this patch, I just used the standard command line "git format-patch" command. What do I need to change to make a patch appliable by Egit? Corey and I spoke about this on IRC, but to close the loop here on the bug: I pointed Corey to the EGit user guide, especially this section: http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches Although I may have been bitten by: http://wiki.eclipse.org/EGit/User_Guide#Applying_Patches "Currently it s not possible to apply all patches in git format. It is possible to apply patches using the standard Eclipse (unified diff) format using Team > Apply Patch.... Git patches may contain non-standard extensions for rename and binary diffs. The current version of EGit does not generate these extensions. " |
Created attachment 192145 [details] Improves error message when opcontrol returns a non-zero status On systems without /usr/bin/consolehelper, you must run the install_noconsolehelper.sh which causes you to edit the /etc/sudoers file. If this editing wasn't done correctly, or was performed by another user, opcontrol will return an error code, essentially saying that "sudo opcontrol" failed. The error message given by the oprofile plug-in is obtuse. I have created and attached a small patch to improve the error message.