Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 341287

Summary:

o.e.e.p2.transport.ecf bundle needlessly includes org.eclipse.core.runtime

Product:

[Eclipse Project] Equinox

Reporter:

Scott Lewis <slewis>

Component:

Assignee:

P2 Inbox <equinox.p2-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.7

Target Milestone:

3.7 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch to eliminate require-bundle dependency on o.e.core.runtime	none

Description Scott Lewis

2011-03-29 17:06:40 EDT

In the newly added bundle:  org.eclipse.equinox.p2.transport.ecf 

the manifest.mf has:

Require-Bundle: org.eclipse.ecf;bundle-version="3.1.0",
 org.eclipse.ecf.filetransfer;bundle-version="4.0.0",
 org.eclipse.ecf.provider.filetransfer;bundle-version="3.1.0",
 org.eclipse.core.runtime;bundle-version="3.6.100",              <----
 org.eclipse.equinox.p2.core;bundle-version="2.0.100",
 org.eclipse.equinox.p2.repository;bundle-version="2.1.0"

This means that org.eclipse.core.runtime gets pulled into any application (e.g. osgi server-side app) that uses both p2 and the ECF filetransfer.  It would be much better to require-bundle with equinox common, and include packages for the other dependencies so as to eliminate the need for org.eclipse.core.runtime.

See also bug 341285 for bug in p2 server feature that is missing the o.e.e.p2.transport.ecf bundle.

Comment 1 Scott Lewis

2011-03-29 17:15:12 EDT

Created attachment 192144 [details]
patch to eliminate require-bundle dependency on o.e.core.runtime

This patch removes the Require-Bundle dependency on org.eclipse.core.runtime and replaces it with Require-Bundle on org.eclipse.equinox.common plus a number of Import-Package of various packages (jobs, osgi packageadmin, tracker, etc).

Comment 2 DJ Houghton

2011-03-29 17:19:22 EDT

Thanks Scott. I actually fixed this just before seeing your patch. I just changed the require bundle to include osgi and jobs and common.